Closed Bug 1713610 Opened 3 years ago Closed 3 years ago

Remove "./mach vendor python [package]", mandate that package is in "requirements.in"

Categories

(Firefox Build System :: Mach Core, task)

task

Tracking

(firefox91 fixed)

RESOLVED FIXED
91 Branch
Tracking Status
firefox91 --- fixed

People

(Reporter: mhentges, Assigned: mhentges)

Details

Attachments

(1 file)

This ensures that we have pinned packages and that the package is compatible with the other ones we have pinned.
This doc will need to be updated.

Assignee: nobody → mhentges
Status: NEW → ASSIGNED

./mach vendor python <package> was already adding its new package
to requirements.txt, so we were getting full resolver support, which
is good. However, it caused our requirements.in file to start
getting out-of-date, and made it harder to identify the top-level
dependencies.

Arguably, we could have ./mach vendor python <package> automatically
update requirements.in, too, but then we need to solve the edge cases,
such as "What if the package is already in requirements.in? What if
that existing item had a different version?"
The hardest part of updating requirements.in is finding it, so I've
also modified the ./mach vendor python help text to make it more
identifiable.

Pushed by mhentges@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/10c4df33bc80 Require PyPI-vendored packages be added to requirements.in r=ahal
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 91 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: