1713635 - Interventions on android-components broken

Status: RESOLVED FIXED

(Web Compatibility :: Interventions, defect, P1)

Description

[Dennis Schubert [:denschub]]

Currently, the interventions (and shims) are broken in android-components, because the interventions addon fails to load. inside run.js, it throws:

Uncaught Error: Incorrect argument types for tabs.onUpdated.
    _registerShims moz-extension://145ff6a9-410e-4cda-8534-fca729695095/lib/shims.js:347
    Shims moz-extension://145ff6a9-410e-4cda-8534-fca729695095/lib/shims.js:294
    <anonymous> moz-extension://145ff6a9-410e-4cda-8534-fca729695095/run.js:13

This code was added recently (in bf48ec7, and appears to be working fine on desktop afaict.

Comment 1

[Dennis Schubert [:denschub]]

Also, proposal: We probably should wrap each component (interventions, uaoverrides, shims, aboutcompat-broker) into their own try-catch block. It's not great if, for example, shims break - but if other interventions could keep working, that'd be better.

Comment 2

[Thomas Wisniewski [:twisniewski]]

The problem is that on Fenix the tabs.onUpdated.addListener doesn't accept the properties parameter. I can work around this easily enough, patch incoming.

Comment 3

[Thomas Wisniewski [:twisniewski]]

Attachment: Bug 1713635 - Work around a lack of support for the properties parameter of browser.tabs.onUpdated in GeckoView, so the webcompat addon starts up properly there; r?denschub

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a7be7437c9df
Work around a lack of support for the properties parameter of browser.tabs.onUpdated in GeckoView, so the webcompat addon starts up properly there; r=denschub,webcompat-reviewers

Comment 5

[Dennis Schubert [:denschub]]

Attachment: GitHub Pull Request

Submitted a PR for android-components before this landed in central to speed up the process a bit.

Comment 6

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/a7be7437c9df

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7a2f2eafc660
[components] Bug 1713635 - Import v23.1.10 of feature-webcompat.