Closed Bug 1713643 Opened 3 years ago Closed 3 years ago

Use DOCUMENT_EVENT's will-navigate event to clear ResourceCommand internal cache

Categories

(DevTools :: Framework, task)

task

Tracking

(Fission Milestone:M8, firefox91 fixed)

RESOLVED FIXED
91 Branch
Fission Milestone M8
Tracking Status
firefox91 --- fixed

People

(Reporter: ochameau, Assigned: ochameau)

References

(Blocks 1 open bug)

Details

(Whiteboard: dt-fission-m3-mvp)

Attachments

(3 files)

Bug 1712592 introduced DOCUMENT_EVENT will-navigate resource in order to replace target's will-navigate event.
ResourceCommand is still using the target event and should use the resource instead, which is more resilient with cross process navigation.

Assignee: nobody → poirot.alex
Status: NEW → ASSIGNED
Whiteboard: dt-fission-m3-triage
Depends on: 1713297

We were calling ResourceCommand.watchResources from onTargetAvailable, whereas we could and should
call it once before or after calling TargetCommand.watchTargets.
Doing this helps calling watchResources only once, for all the resource types.

Also tweaked networkFront and responsiveFront instantiation.
to only instantiate them when we need them.

Doing this helps knowing if some resources are coming from ResourceCommand cache,
or if they are live resources coming from the server.

Whiteboard: dt-fission-m3-triage → dt-fission-m3-mvp
Fission Milestone: --- → M8
Attachment #9225551 - Attachment description: Bug 1713643 - [devtools] Expose isExistingResources argument via onResourceAvailable callbacks. → Bug 1713643 - [devtools] Expose areExistingResources argument via onResourceAvailable callbacks.
Pushed by apoirot@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/ffb738eeaa47
[devtools] Watch for netmonitor resources from a single place. r=bomsy
https://hg.mozilla.org/integration/autoland/rev/820149ffdf51
[devtools] Expose areExistingResources argument via onResourceAvailable callbacks. r=jdescottes
https://hg.mozilla.org/integration/autoland/rev/77d3ebb0c056
[devtools] Use DOCUMENT_EVENT will-navigate in ResourceCommand to prune its cache. r=nchevobbe,jdescottes,bomsy
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 91 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: