Closed Bug 1713654 Opened 3 years ago Closed 3 years ago

Perfherder compare view never finishes loading (e.find is not a function)

Categories

(Tree Management :: Perfherder, defect, P1)

Product:
Tree Management
Component:
Perfherder
Type:
defect

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: jdescottes, Assigned: bacasandrei)

References

(Regression)

Details

Attachments

(1 file)

Link to GitHub pull-request: https://github.com/mozilla/treeherder/pull/7169
47 bytes, text/x-github-pull-request
Details | Review

STRs: open https://treeherder.mozilla.org/perfherder/comparesubtest?originalProject=try&newProject=try&newRevision=1f427250535471bb3c6f72903c28329334f15c8a&originalSignature=3130994&newSignature=3130994&framework=12&originalRevision=69adf280c487ed7e22d021598af4efe65e8519fe

ER: should load

AR: Error in console

20:37:06.090 Uncaught (in promise) TypeError: e.find is not a function
    getDisplayResults CompareSubtestsView.jsx:124
    getDisplayResults CompareSubtestsView.jsx:123
    getPerformanceData CompareTableView.jsx:188
CompareSubtestsView.jsx:124:40

I think this was regressed by Bug 1706469.
CompareView.jsx was properly updated by it seems CompareSubtestsView.jsx was not.

Flags: needinfo?(beatrice.acasandrei)
Regressed by: 1706469
Assignee: nobody → airimovici
Status: NEW → ASSIGNED
Priority: -- → P2
Assignee: airimovici → beatrice.acasandrei
Priority: P2 → P1

(In reply to Julian Descottes [:jdescottes] from comment #1)

I think this was regressed by Bug 1706469.
CompareView.jsx was properly updated by it seems CompareSubtestsView.jsx was not.

You are correct. I made a PR with the fix. Thanks.

Flags: needinfo?(beatrice.acasandrei)
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: