Closed Bug 1713669 Opened 3 years ago Closed 3 years ago

[wpt-sync] Sync PR 29167 - Fix WebXR stencil test

Categories

(Core :: WebVR, task, P4)

Product:
Core
Component:
WebVR
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
91 Branch
Tracking Flags:
Tracking Status
firefox91 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 29167 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/29167
Details from upstream follow.

b'Alexis Hetu <sugoi@google.com>' wrote:

Fix WebXR stencil test

According to the WebGL spec, about the readPixel() function:
"Only two combinations of format and type are accepted. The
first is format RGBA and type UNSIGNED_BYTE. The second is
an implementation-chosen format. The values of format and
type for this format may be determined by calling
getParameter with the symbolic constants
IMPLEMENTATION_COLOR_READ_FORMAT and
IMPLEMENTATION_COLOR_READ_TYPE, respectively. The
implementation-chosen format may vary depending on the
format of the currently bound rendering surface.
Unsupported combinations of format and type will generate
an INVALID_OPERATION error."

This means using GL_RGB is platform dependent, while using
GL_RGBA is supported by all platforms, so the test was
modified to use GL_RGBA in order to be spec compliant.

Bug: chromium:1204234
Change-Id: Icfc9236f5281f5bc9d396b1dce1a86978facf8c8

Reviewed-on: https://chromium-review.googlesource.com/2929277
WPT-Export-Revision: 83b0bd82d1a319598b3ba33008f4a304f68b4f81

Component: web-platform-tests → WebVR
Product: Testing → Core

CI Results

Ran 15 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 4 subtests

Status Summary

Firefox

OK : 1
FAIL: 4

Chrome

OK : 1
FAIL: 4

Safari

OK : 1
FAIL: 2

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/webxr/xrWebGLLayer_opaque_framebuffer_stencil.https.html: OK [Gecko-linux1804-64-debug, Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-linux1804-64-tsan-opt, Gecko-windows10-32-debug, Gecko-windows10-32-opt, Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, GitHub], SKIP [Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview] (Chrome: OK, Safari: OK)
Ensure that the framebuffer given by the WebGL layer works with stencil for non-immersive - webgl: FAIL (Chrome: FAIL)
Ensure that the framebuffer given by the WebGL layer works with stencil for non-immersive - webgl2: FAIL (Chrome: FAIL)
Ensure that the framebuffer given by the WebGL layer works with stencil for immersive - webgl: FAIL (Chrome: FAIL, Safari: FAIL)
Ensure that the framebuffer given by the WebGL layer works with stencil for immersive - webgl2: FAIL (Chrome: FAIL, Safari: FAIL)

Tests Disabled in Gecko Infrastructure

/webxr/xrWebGLLayer_opaque_framebuffer_stencil.https.html: OK [Gecko-linux1804-64-debug, Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-linux1804-64-tsan-opt, Gecko-windows10-32-debug, Gecko-windows10-32-opt, Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, GitHub], SKIP [Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview] (Chrome: OK, Safari: OK)

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/c41fc5ead22d
[wpt PR 29167] - Fix WebXR stencil test, a=testonly

https://hg.mozilla.org/mozilla-central/rev/c41fc5ead22d

Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox91: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 91 Branch
You need to log in before you can comment on or make changes to this bug.