1713683 - Perma [tier2] tools/lint/test/test_black.py::test_lint_fix[black] ERROR | E KeyError: 'log'

Status: RESOLVED FIXED

(Developer Infrastructure :: Lint and Formatting, defect)

Description

Z:\task_1622497735\build\src\tools\lint\test\test_black.py
[task 2021-05-31T22:00:53.607Z]  0:23.76 ============================= test session starts =============================
[task 2021-05-31T22:00:53.607Z]  0:23.76 platform win32 -- Python 3.6.5, pytest-3.6.2, py-1.10.0, pluggy-0.6.0 -- Z:\task_1622497735\build\src\obj-x86_64-pc-mingw32\_virtualenvs\python-test\Scripts\python.exe
[task 2021-05-31T22:00:53.607Z]  0:23.76 rootdir: Z:\task_1622497735\build\src, inifile: Z:\task_1622497735\build\src\config\mozunit\mozunit\pytest.ini
[task 2021-05-31T22:00:53.607Z]  0:23.76 collecting ... collected 2 items
[task 2021-05-31T22:00:53.607Z]  0:23.76 
[task 2021-05-31T22:00:53.607Z]  0:23.76 tools/lint/test/test_black.py::test_lint_fix[black] ERROR
[task 2021-05-31T22:00:53.607Z]  0:23.76 tools/lint/test/test_black.py::test_lint_black[black] ERROR
[task 2021-05-31T22:00:53.607Z]  0:23.76 
[task 2021-05-31T22:00:53.607Z]  0:23.76 =================================== ERRORS ====================================
[task 2021-05-31T22:00:53.607Z]  0:23.76 ___________________ ERROR at setup of test_lint_fix[black] ____________________
[task 2021-05-31T22:00:53.607Z]  0:23.76 
[task 2021-05-31T22:00:53.607Z]  0:23.76 config = {'description': 'Reformat python', 'exclude': ['gfx/harfbuzz/src/meson.build', 'layout/style/ServoCSSPropList.mako.py'...eb-platform/mozilla/tests/tools/wptserve_py2', ...], 'extensions': ['build', 'configure', 'py'], 'include': ['.'], ...}
[task 2021-05-31T22:00:53.607Z]  0:23.76 
[task 2021-05-31T22:00:53.607Z]  0:23.76     @pytest.fixture(autouse=True)
[task 2021-05-31T22:00:53.607Z]  0:23.76     def run_setup(config):
[task 2021-05-31T22:00:53.607Z]  0:23.76         """Make sure that if the linter named in the LINTER global variable has a
[task 2021-05-31T22:00:53.607Z]  0:23.76         setup function, it gets called before running the tests.
[task 2021-05-31T22:00:53.607Z]  0:23.76         """
[task 2021-05-31T22:00:53.607Z]  0:23.76         if "setup" not in config:
[task 2021-05-31T22:00:53.607Z]  0:23.76             return
[task 2021-05-31T22:00:53.607Z]  0:23.76 
[task 2021-05-31T22:00:53.607Z]  0:23.76         func = findobject(config["setup"])
[task 2021-05-31T22:00:53.607Z]  0:23.76 >       func(build.topsrcdir, virtualenv_manager=build.virtualenv_manager)
[task 2021-05-31T22:00:53.607Z]  0:23.76 
[task 2021-05-31T22:00:53.607Z]  0:23.76 tools\lint\test\conftest.py:97:
[task 2021-05-31T22:00:53.608Z]  0:23.76 _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
[task 2021-05-31T22:00:53.608Z]  0:23.76 
[task 2021-05-31T22:00:53.608Z]  0:23.76 root = 'Z:/task_1622497735/build/src'
[task 2021-05-31T22:00:53.608Z]  0:23.76 lintargs = {'virtualenv_manager': <mozbuild.virtualenv.VirtualenvManager object at 0x00000129A0441DD8>}
[task 2021-05-31T22:00:53.608Z]  0:23.76 
[task 2021-05-31T22:00:53.608Z]  0:23.76     def setup(root, **lintargs):
[task 2021-05-31T22:00:53.608Z]  0:23.76 >       log = lintargs["log"]
[task 2021-05-31T22:00:53.608Z]  0:23.76 E       KeyError: 'log'
 0:23.76 
[task 2021-05-31T22:00:53.609Z]  0:23.76 tools\lint\python\black.py:114: KeyError
[task 2021-05-31T22:00:53.609Z]  0:23.76 __________________ ERROR at setup of test_lint_black[black] ___________________
[task 2021-05-31T22:00:53.609Z]  0:23.76 
[task 2021-05-31T22:00:53.609Z]  0:23.76 config = {'description': 'Reformat python', 'exclude': ['gfx/harfbuzz/src/meson.build', 'layout/style/ServoCSSPropList.mako.py'...eb-platform/mozilla/tests/tools/wptserve_py2', ...], 'extensions': ['build', 'configure', 'py'], 'include': ['.'], ...}
[task 2021-05-31T22:00:53.609Z]  0:23.76 
[task 2021-05-31T22:00:53.609Z]  0:23.76     @pytest.fixture(autouse=True)
[task 2021-05-31T22:00:53.609Z]  0:23.76     def run_setup(config):
[task 2021-05-31T22:00:53.610Z]  0:23.76         """Make sure that if the linter named in the LINTER global variable has a
[task 2021-05-31T22:00:53.610Z]  0:23.76         setup function, it gets called before running the tests.
[task 2021-05-31T22:00:53.610Z]  0:23.76         """
[task 2021-05-31T22:00:53.610Z]  0:23.76         if "setup" not in config:
[task 2021-05-31T22:00:53.610Z]  0:23.76             return
[task 2021-05-31T22:00:53.610Z]  0:23.76 
[task 2021-05-31T22:00:53.610Z]  0:23.76         func = findobject(config["setup"])
[task 2021-05-31T22:00:53.611Z]  0:23.76 >       func(build.topsrcdir, virtualenv_manager=build.virtualenv_manager)
[task 2021-05-31T22:00:53.611Z]  0:23.76 
[task 2021-05-31T22:00:53.611Z]  0:23.76 tools\lint\test\conftest.py:97:
[task 2021-05-31T22:00:53.611Z]  0:23.76 _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
[task 2021-05-31T22:00:53.611Z]  0:23.76 
[task 2021-05-31T22:00:53.611Z]  0:23.76 root = 'Z:/task_1622497735/build/src'
[task 2021-05-31T22:00:53.611Z]  0:23.76 lintargs = {'virtualenv_manager': <mozbuild.virtualenv.VirtualenvManager object at 0x00000129A0441DD8>}
[task 2021-05-31T22:00:53.611Z]  0:23.76 
[task 2021-05-31T22:00:53.611Z]  0:23.76     def setup(root, **lintargs):
[task 2021-05-31T22:00:53.611Z]  0:23.76 >       log = lintargs["log"]
[task 2021-05-31T22:00:53.611Z]  0:23.76 E       KeyError: 'log'
[task 2021-05-31T22:00:53.611Z]  0:23.76 
[task 2021-05-31T22:00:53.612Z]  0:23.76 tools\lint\python\black.py:114: KeyError
[task 2021-05-31T22:00:53.612Z]  0:23.76 =========================== 2 error in 0.24 seconds ===========================
[task 2021-05-31T22:00:53.612Z]  0:23.76 Setting retcode to 1 from Z:\task_1622497735\build\src\tools\lint\test\test_black.py
[task 2021-05-31T22:00:55.792Z]  0:25.94 Z:\task_1622497735\build\src\tools\lint\test\test_clang_format.py
[task 2021-05-31T22:00:55.793Z]  0:25.94 ============================= test session starts =============================
[task 2021-05-31T22:00:55.793Z]  0:25.94 platform win32 -- Python 3.6.5, pytest-3.6.2, py-1.10.0, pluggy-0.6.0 -- Z:\task_1622497735\build\src\obj-x86_64-pc-mingw32\_virtualenvs\python-test\Scripts\python.exe
[task 2021-05-31T22:00:55.793Z]  0:25.94 rootdir: Z:\task_1622497735\build\src, inifile: Z:\task_1622497735\build\src\config\mozunit\mozunit\pytest.ini
[task 2021-05-31T22:00:55.793Z]  0:25.94 collecting ... collected 4 items
[task 2021-05-31T22:00:55.793Z]  0:25.94 
[task 2021-05-31T22:00:55.793Z]  0:25.94 tools/lint/test/test_clang_format.py::test_good[clang-format] PASSED

Comment 1

[Nick Alexander :nalexander [he/him]]

Attachment: Bug 1713683 - Run `setup` function with `lintargs` including log and virtual env binary path. r?ahal

This was oversight from Bug 1713178, which made black's setup
function require them but didn't bump the test.

Comment 2

[Nick Alexander :nalexander [he/him]]

Attachment: Bug 1713683 - Post: Run `test_black` on macOS. r?ahal

Depends on D116493

Comment 3

[Nick Alexander :nalexander [he/him]]

Try build is percolating at https://treeherder.mozilla.org/#/jobs?repo=try&revimsion=8e61d550f3d0b20532fefe8da1bc8ced123955bf. Enabling test_black on macOS is speculative; if it still fails on macOS I'll abandon the commit.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3b8e222daf8d
Run `setup` function with `lintargs` including log and virtual env binary path. r=ahal

Comment 5

[Intermittent Failures Robot]

24 failures in 626 pushes (0.038 failures/push) were associated with this bug yesterday.

Repository breakdown:

• autoland: 23
• mozilla-central: 1

Platform and build breakdown:

• linux1804-64: 23
  • opt: 23
• windows10-64: 1
  • opt: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1713683&startday=2021-06-02&endday=2021-06-02&tree=all

Comment 6

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/3b8e222daf8d

Comment 7

[Intermittent Failures Robot]

30 failures in 3065 pushes (0.01 failures/push) were associated with this bug in the last 7 days.

** This failure happened more than 30 times this week! Resolving this bug is a high priority. **

** Try to resolve this bug as soon as possible. If unresolved for 2 weeks, the affected test(s) may be disabled. **

Repository breakdown:

• autoland: 27
• mozilla-central: 3

Platform and build breakdown:

• linux1804-64: 26
  • opt: 26
• windows10-64: 4
  • opt: 4

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1713683&startday=2021-05-31&endday=2021-06-06&tree=all