1713687 - Improve the ETP shim for Google Analytics and fold the Tag Manager shim into it

Status: RESOLVED FIXED

(Core :: Privacy: Anti-Tracking, enhancement)

Description

[Thomas Wisniewski [:twisniewski]]

Some request the script with get-parameters, which the shim currently does not match. The shim can also more thoroughly stub out and mimic the API to prevent some more obscure site breakage.

Comment 1

[Thomas Wisniewski [:twisniewski]]

It actually seems like we can drop the dedicated Tag Manager shim and just perform its functions in the GA shim, as per my thoughts in bug 1713687. I think we ought to do that to simplify the code as well as cover the case where a webpage only loads one of the scripts, rather than both, yet relies on the dataLayer to be processed regardless.

Comment 2

[Thomas Wisniewski [:twisniewski]]

Attachment: Bug 1713687 - Improve the ETP shim for Google Analytics and fold the Tag Manager shim into it; r?denschub

• add wildcards to the URLs, as some sites access the scripts with GET parameters.
• we don't actually need a standalone Tag Manager shim, so just re-use the GA one.
• this will also mitigate breakage on some sites which load only one of the two scripts.
• more thoroughly stub out the Analytics window object to mitigate more site breakage.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2e82d85e50b4
Improve the ETP shim for Google Analytics and fold the Tag Manager shim into it; r=webcompat-reviewers,denschub

Comment 4

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/2e82d85e50b4

Comment 5

[Thomas Wisniewski [:twisniewski]]

(commented on the wrong bug)

Comment 6

[expert.rnarn]

Hey, I have NO IDEA what am I doing here guys, but please...just explain me is this bad or good that Firefox shimming GA and TM? Just ckecked out console today and got redirected here.

Comment 7

[expert.rnarn]

i mean checked, not ckecked :)))

Comment 8

[Thomas Wisniewski [:twisniewski]]

Firefox only shims them when they would otherwise be blocked by strict or private browsing's tracking protection. It does so because when they are simply blocked, quite a few sites will break (sometimes in minor ways, and sometimes completely).

Whether that's a good or bad thing is entirely up to you. You are free to disable SmartBlock if you'd prefer not to activate any shims (in about:config, the extensions.webcompat.enable_shims setting) at the expense of more websites breaking while using stricter tracking protection.

Hope that helps!