1713778 - ntp_text theme property does not change the font color of the new tab page

Status: VERIFIED FIXED

(Firefox :: New Tab Page, defect, P3)

Description

[Rob Wu [:robwu]]

STR:

1. Visit https://color.firefox.com and install the extension.
2. Go to the "Advanced colors" tab and set "New Tab Background Color" to a red color and "New Tab Text" to white.
3. Open a new tab
4. Look at the colors

Expected:

• The background should be red.
• The text on the background (e.g. "Recommended by Pocket" and the text of the tiles) should be white.

Actual:

• The background is red as expected.
• The text is still black.

This is a regression from bug 1686384, because it introduced the --newtab-background-primary-text-color CSS variable without mirroring the extension-defined ntp_text to it.

The unit tests at browser_ext_themes_ntp_colors.js and browser_ext_themes_ntp_colors_perwindow.js did not catch this because we don't have test coverage for this specific aspect.

Comment 1

[Shane Caraveo (:mixedpuppy)]

Any chance you or someone working on newtab can look at this regression?

Comment 2

[Erica Wright [:ewright]]

(In reply to Shane Caraveo (:mixedpuppy) from comment #1)

Any chance you or someone working on newtab can look at this regression?
I'm not sure who is on newtab anymore, I'm no longer working at Moz.

Comment 3

[Scott [:thecount] Downe]

Amy this is probably something that is worth looking at from a newtab triage point of view.

I also think it might make sense to move this into the newtab or topsites component, too?

Comment 4

[Harry Twyford]

Like comment 0 said, new-new-tab introduced the variable --newtab-background-primary-text-color which is not themeable. It replaced --newtab-text-primary-color in some cases, which is themeable. We should consider this in bug 1727317.

Comment 6

[Amy Churchwell [:amy]]

Attachment: WIP: Bug 1713778, 1727317 Define the relationships between new tab CSS variables. r=harry!

Comment 7

[Harry Twyford]

This will be fixed in bug 1727319.

Comment 8

[Harry Twyford]

Bug 1727319 landed.

Comment 9

[Marius Coman [:mcoman], Ecosystem QA]

This issue was part of the work done on QA-1182 request. Considering this I am marking it as Verified.