Fix some CSS-variables tests.
Categories
(Core :: CSS Parsing and Computation, defect)
Tracking
()
Tracking | Status | |
---|---|---|
firefox91 | --- | fixed |
People
(Reporter: emilio, Assigned: emilio)
References
Details
Attachments
(3 files)
Assignee | ||
Updated•1 year ago
|
Assignee | ||
Comment 1•1 year ago
|
||
Custom properties are white-space aware and should preserve input, so
the expectation is wrong. In order for serialization to roundtrip you
can't add an space after the colon.
Assignee | ||
Comment 2•1 year ago
|
||
This effectively backs out bug 1623396.
See:
https://github.com/w3c/csswg-drafts/pull/6006
https://drafts.csswg.org/css-variables/#guaranteed-invalid-value
And related discussion. Matches Chrome stable as per https://groups.google.com/a/chromium.org/g/blink-dev/c/0xrbzYe_vxU/m/7bsL76n9CgAJ
Depends on D116459
Assignee | ||
Comment 3•1 year ago
|
||
These tests are not right, they are expecting untyped custom properties
to transition, and that's not how these work.
All browsers time out:
https://wpt.fyi/results/css/css-variables?label=master&label=experimental&aligned
So we should just remove them IMO.
Depends on D116460
Assignee | ||
Updated•1 year ago
|
Pushed by ealvarez@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/0ff00c885d96 Remove some tests that time out in all browsers. r=boris
Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/29188 for changes under testing/web-platform/tests
Comment 6•1 year ago
|
||
bugherder |
Updated•1 year ago
|
Pushed by ealvarez@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/0eff98b29ec0 Make custom properties that are IACVT guaranteed-invalid. r=boris
Comment 8•1 year ago
|
||
bugherder |
Pushed by ealvarez@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/2dc1eff1effd Fix whitespace handling inside CSS variables. r=xidorn
Comment 10•1 year ago
|
||
Pushed by emilio@crisal.io: https://hg.mozilla.org/integration/autoland/rev/1ddacb243ae6 Fix test_variable_serialization_computed.html
Comment 11•1 year ago
|
||
Backed out for wpt failures on declarations-trim-whitespace.html
Backout link: https://hg.mozilla.org/integration/autoland/rev/185f73dea85b3fb3e5042914e9ef6233a826b6ed
Log link: https://treeherder.mozilla.org/logviewer?job_id=341908841&repo=autoland&lineNumber=2145
Comment 12•1 year ago
|
||
Upstream PR merged by moz-wptsync-bot
Updated•1 year ago
|
Assignee | ||
Updated•1 year ago
|
Comment 14•1 year ago
|
||
Pushed by ealvarez@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/d55d07d3e8cc Fix whitespace handling inside CSS variables. r=xidorn
Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/29255 for changes under testing/web-platform/tests
Assignee | ||
Updated•1 year ago
|
Comment 16•1 year ago
|
||
bugherder |
Upstream PR merged by moz-wptsync-bot
Description
•