1713787 - Fix some CSS-variables tests.

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect)

Comment 1

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1713787 - Fix whitespace handling inside CSS variables. r=xidorn

Custom properties are white-space aware and should preserve input, so
the expectation is wrong. In order for serialization to roundtrip you
can't add an space after the colon.

Comment 2

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1713787 - Make custom properties that are IACVT guaranteed-invalid. r=#style

This effectively backs out bug 1623396.

See:

https://github.com/w3c/csswg-drafts/pull/6006
https://drafts.csswg.org/css-variables/#guaranteed-invalid-value

And related discussion. Matches Chrome stable as per https://groups.google.com/a/chromium.org/g/blink-dev/c/0xrbzYe_vxU/m/7bsL76n9CgAJ

Depends on D116459

Comment 3

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1713787 - Remove some tests that time out in all browsers. r=#style

These tests are not right, they are expecting untyped custom properties
to transition, and that's not how these work.

All browsers time out:

https://wpt.fyi/results/css/css-variables?label=master&label=experimental&aligned

So we should just remove them IMO.

Depends on D116460

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0ff00c885d96
Remove some tests that time out in all browsers. r=boris

Comment 5

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/29188 for changes under testing/web-platform/tests

Comment 6

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/0ff00c885d96

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0eff98b29ec0
Make custom properties that are IACVT guaranteed-invalid. r=boris

Comment 8

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/0eff98b29ec0

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2dc1eff1effd
Fix whitespace handling inside CSS variables. r=xidorn

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1ddacb243ae6
Fix test_variable_serialization_computed.html

Comment 11

[Narcis Beleuzu [:NarcisB]]

Backed out for wpt failures on declarations-trim-whitespace.html

Backout link: https://hg.mozilla.org/integration/autoland/rev/185f73dea85b3fb3e5042914e9ef6233a826b6ed
Log link: https://treeherder.mozilla.org/logviewer?job_id=341908841&repo=autoland&lineNumber=2145

Comment 12

[Narcis Beleuzu [:NarcisB]]

Plase also check https://treeherder.mozilla.org/logviewer?job_id=341909245&repo=autoland&lineNumber=4898

Comment 13

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d55d07d3e8cc
Fix whitespace handling inside CSS variables. r=xidorn

Comment 15

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/29255 for changes under testing/web-platform/tests

Comment 16

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/d55d07d3e8cc

Comment 17

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot