Closed Bug 1713811 Opened 3 years ago Closed 3 years ago

Tweak lazy-loading root margin defaults to 1000px in all directions

Categories

(Core :: Layout, task)

task

Tracking

()

RESOLVED FIXED
91 Branch
Tracking Status
firefox91 --- fixed

People

(Reporter: sefeng, Assigned: sefeng)

References

Details

Attachments

(1 file)

In bug 1703048, we changed the threshold from 300px to 600px which brings

  • lazyload_image_not_viewport: a ~22% regression (7 to 9) for the 95 percentile. Meaning more images were lazy-loaded but didn't reach the viewport.
  • lazyload_image_viewport_loaded: a 5% to 10% improvements (~18 to 20) for the 95 percentile. Meaning more images were lazy-loaded and reached the viewport.
  • lazyload_image_viewport_loading: a 15% to 20% improvements for the 95 percentile. Meaning lazy-loaded images that were still loading when they reached the viewport.
  • fx_lazyload_image_page_load_ms: Looks stable. Meaning no visible page load performance regression.

Per https://bugs.webkit.org/show_bug.cgi?id=203557#c37, we may want to try 1000px.

Summary: Tweak lazy-loading root margin defaults to 100px in all directions → Tweak lazy-loading root margin defaults to 1000px in all directions
Assignee: nobody → sefeng
Status: NEW → ASSIGNED
Pushed by sefeng@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/3ddd9e5bd415
Tweak lazy-loading root margin defaults to 1000px in all directions for EARLY_BETA_OR_EARLIER r=emilio
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 91 Branch

Tweaking to 1000px brings us these:

lazyload_image_not_viewport: a 30% regression compare to 600px for 95 percentile, and 40% regression compare to 300px for 95 percentile.
lazyload_image_viewport_loaded: Maybe a slight/tiny improvement compare to 600px, however it wasn't very noticeable
lazyload_image_viewport_loading: also maybe a slight/tiny improvement compare to 600px, also not very noticeable
fx_lazyload_image_page_load_ms: Page load seems to be regressed about 5% - 10% for the 75 percentile

I don't think 1000px threshold looks good, perhaps we may want to try 700px or 800px to eliminate the regression for lazyload_image_not_viewport and fx_lazyload_image_page_load_ms? What do you think Emilio

Flags: needinfo?(emilio)

Yeah, that sounds worth trying to me.

Flags: needinfo?(emilio)
Blocks: 1722574
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: