1713825 - Update invalid "exception.message" usages

Status: RESOLVED FIXED

(Firefox Build System :: Mach Core, defect, P3)

Description

[Mitchell Hentges [:mhentges] 🦀]

In PEP 352, exception.message was deprecated (now, you can get the string from of an exception by simply doing str(exception). As of Python 3.0, exception.message was dropped, and attempting to access it causes an error.

Thanks to Ahal for pointing out that we have a lot of code that still attempts to use exception.message.

Comment 1

[Andrey Bienkowski]

vendored 3rd party code:

• pyrsistent used to use exception.message until this PR: https://github.com/tobgu/pyrsistent/pull/226
• click is still using exception.message: https://github.com/pallets/click/pull/1946
• there might be more

Comment 2

[Mitchell Hentges [:mhentges] 🦀]

The remaining usages are all in 3rd-party code. Thanks Andrey!