Closed Bug 1713887 Opened 3 years ago Closed 3 years ago

Tests skipped in 'accessible/tests/browser/hittest/browser.ini' for new Fission platform triage

Categories

(Core :: Disability Access APIs, task)

task

Tracking

()

RESOLVED INVALID
Tracking Status
firefox-esr78 --- disabled
firefox89 --- disabled
firefox90 --- disabled
firefox91 --- affected

People

(Reporter: ahal, Unassigned)

References

Details

The following tests were disabled in accessible/tests/browser/hittest/browser.ini due to new Fission platform triage:
browser_test_general.js

Full diff:

diff --git a/accessible/tests/browser/hittest/browser.ini b/accessible/tests/browser/hittest/browser.ini
--- a/accessible/tests/browser/hittest/browser.ini
+++ b/accessible/tests/browser/hittest/browser.ini
@@ -5,11 +7,13 @@ support-files =
   !/accessible/tests/browser/*.jsm
   !/accessible/tests/mochitest/*.js
   !/accessible/tests/mochitest/letters.gif
 
 [browser_test_browser.js]
 [browser_test_canvas_hitregion.js]
 skip-if = os == "android"
 [browser_test_general.js]
+skip-if =
+  fission && debug && os == "mac"  # New platform triage
 [browser_test_shadowroot.js]
 [browser_test_zoom_text.js]
 [browser_test_zoom.js]

See the following try push for failures:
https://treeherder.mozilla.org/jobs?repo=try&revision=ad7a18fdad3b8e35b44152c16d94babb80387cd8

To run these failures in your own try push, first revert the skip-if
annotations, then run:

$ ./mach try fuzzy --rebuild 3 accessible/tests/browser/hittest/browser.ini

Then use the fuzzy interface to select the task(s) which are relevant to the
removed skip-if expression(s). Please note the failure may be intermittent
and/or been fixed since the triage took place.

We need to determine whether this browser-chrome test failure should block shipping Fission. Tracking for Fission Milestone M7a for the initial audit. Then we can decide whether to move this bug to Fission M8 or post-MVP (Fission Future).

Here is a recent Try run for Fission browser-chrome:

https://treeherder.mozilla.org/jobs?repo=try&revision=ad7a18fdad3b8e35b44152c16d94babb80387cd8

Blocks: 1694824
Fission Milestone: --- → M7a
Blocks: a11y-fission

I'm a little confused. The push health for that try run doesn't show a failure for accessible/tests/browser/hittest/browser_test_general.js. Am I missing something?

Flags: needinfo?(cpeterson)

(In reply to James Teh [:Jamie] from comment #2)

I'm a little confused. The push health for that try run doesn't show a failure for accessible/tests/browser/hittest/browser_test_general.js. Am I missing something?

Hmm. I don't see any failures from this test in that try run either.

I checked :ahal's other recent browser-chrome try runs and I don't see any hittest/browser_test_general.js failures. I will ping :ahal in the review of his annotation patch for bug 1694824. I will leave my needinfo for this bug as a reminder. If :ahal lands bug 1694824's annotation for hittest/browser_test_general.js before I get answer and the annotation turns out to be unnecessary, then we can use this bug to remove the annotation.

Enabling new platforms is messy. In this case there were dozens of failures, pre-existing intermittents and the patch was created over the span of weeks. To get coverage on these platforms ASAP, I was erring on the side of over-disabling when in doubt. So it's possible I either made a mistake, the problem was fixed between now and when I first annotated the manifest, or the test is intermittent and just happened to not fail on these three tasks.

But thanks for catching, I removed this annotation from the patch prior to landing.

Status: NEW → RESOLVED
Closed: 3 years ago
Flags: needinfo?(cpeterson)
Resolution: --- → INVALID
Fission Milestone: M7a → ---
You need to log in before you can comment on or make changes to this bug.