Closed Bug 1713903 Opened 3 years ago Closed 3 years ago

Tests skipped in 'docshell/test/browser/browser.ini' for new Fission platform triage

Categories

(Core :: DOM: Navigation, task, P2)

Product:
Core
Component:
DOM: Navigation
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
91 Branch
Project Flags:
Fission Milestone M7a
Tracking Flags:
Tracking Status
firefox-esr78 --- disabled
firefox89 --- disabled
firefox90 --- disabled
firefox91 --- fixed

People

(Reporter: ahal, Assigned: nika)

References

Details

Attachments

(1 file)

Bug 1713903 - Unskip new platform fission tests in docshell/test/browser/browser.ini,
48 bytes, text/x-phabricator-request
Details | Review

The following tests were disabled in docshell/test/browser/browser.ini due to new Fission platform triage:
browser_bug1673702.js
browser_backforward_userinteraction.js

Full diff:

--- a/docshell/test/browser/browser.ini
+++ b/docshell/test/browser/browser.ini
@@ -78,16 +78,17 @@ support-files =
   file_bug1691153.html
 
 [browser_alternate_fixup_middle_click_link.js]
 [browser_backforward_userinteraction.js]
 support-files =
   dummy_iframe_page.html
 skip-if =
   os == "linux" && bits == 64 && !debug # Bug 1607713
+  fission && os == "mac" && debug  # New platform triage
 [browser_backforward_userinteraction_about.js]
 [browser_bug1543077-1.js]
 [browser_bug1543077-2.js]
 [browser_bug1543077-3.js]
 [browser_bug1543077-4.js]
 [browser_bug1594938.js]
 [browser_bug1206879.js]
 [browser_bug1309900_crossProcessHistoryNavigation.js]
@@ -98,16 +99,17 @@ skip-if =
 [browser_bug1622420.js]
 support-files =
   file_bug1622420.html
   Bug1622420Child.jsm
 [browser_bug1673702.js]
 skip-if =
     os == "linux" && bits == 64 && os_version == "18.04" && debug # Bug 1674513
     os == "win" # Bug 1674513
+    fission && os == "mac" && debug  # New platform triage
 support-files =
   file_bug1673702.json
   file_bug1673702.json^headers^
 [browser_bug1674464.js]
 skip-if = !fission || !crashreporter # On a crash we only keep history when fission is enabled.
 [browser_bug234628-1.js]
 [browser_bug234628-10.js]
 [browser_bug234628-11.js]

See the following try push for failures:
https://treeherder.mozilla.org/jobs?repo=try&revision=ad7a18fdad3b8e35b44152c16d94babb80387cd8

To run these failures in your own try push, first revert the skip-if
annotations, then run:

$ ./mach try fuzzy --rebuild 3 docshell/test/browser/browser.ini

Then use the fuzzy interface to select the task(s) which are relevant to the
removed skip-if expression(s). Please note the failure may be intermittent
and/or been fixed since the triage took place.

We need to determine whether this browser-chrome test failure should block shipping Fission. Tracking for Fission Milestone M7a for the initial audit. Then we can decide whether to move this bug to Fission M8 or post-MVP (Fission Future).

Here is a recent Try run for Fission browser-chrome:

https://treeherder.mozilla.org/jobs?repo=try&revision=ad7a18fdad3b8e35b44152c16d94babb80387cd8

Blocks: 1694824
Fission Milestone: --- → M7a
status-firefox89: --- → disabled
status-firefox90: --- → disabled
status-firefox91: --- → affected
status-firefox-esr78: --- → disabled
Severity: -- → S3
Priority: -- → P2

Nika, could you review these failures and figure out if these are blockers?

Flags: needinfo?(nika)

(In reply to Chris Peterson [:cpeterson] from comment #2)

Here is the browser_backforward_userinteraction.js failure:

https://treeherder.mozilla.org/push-health/push?repo=try&revision=ad7a18fdad3b8e35b44152c16d94babb80387cd8&testGroup=ki&selectedTest=docshelltestbrowserbrowserbackforwarduserinteractionjs&selectedTaskId=341441017&selectedJobName=docshell%2Ftest%2Fbrowser%2Fbrowser_backforward_userinteraction.js+test-macosx1015-64-qr%2Fopt-mochitest-browser-chrome-fis-e10s-1

This failure is a failure on a macos opt build, whereas the skip annotations from comment 0 are only for debug, so while this looks like a similar issue, it's actually on a build which is not being skipped right now, so isn't relevant to whether these tests should be skipped on mac debug.

Here are some browser_bug1673702.js failures (from other Fission browser-chrome try runs before these new Fission skip-if annotations were added):

https://treeherder.mozilla.org/push-health/push?repo=try&revision=787ca6fe2e8486af2c29b52dfa0d31efbe47c705&testGroup=ki&selectedTest=docshelltestbrowserbrowserbug1673702js&selectedTaskId=&selectedJobName=browser%2Fbase%2Fcontent%2Ftest%2Fgeneral%2Fbrowser_save_video_frame.js+test-windows10-64-qr%2Fdebug-mochitest-browser-chrome-fis-e10s-4

This failure is on Linux, not on a macos debug build, so again I think it's not the issue which caused this test to be disabled, but an unrelated intermittent.

https://treeherder.mozilla.org/push-health/push?repo=try&revision=9a909c9c85f4312ce5c869ccac1df79f225b5182&testGroup=ki&selectedTest=docshelltestbrowserbrowserbug1673702js&selectedTaskId=

Both of these are on optimized builds, one for macos and one for linux, so this is an unrelated intermittent which isn't being skipped by the annotations added in this bug.

Given that all of the reproduction cases which :cpeterson could find were on a different platform than the one which it is being skipped for, I think this is not a platform specific intermittent, and the annotations should be removed.

Flags: needinfo?(nika)

Thanks Nika. Please go ahead and re-enable the tests. I can r+ if you'd like.

Assignee: nobody → nika
Status: NEW → ASSIGNED
Pushed by nlayzell@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/5a700fbeef09
Unskip new platform fission tests in docshell/test/browser/browser.ini, r=annyG

https://hg.mozilla.org/mozilla-central/rev/5a700fbeef09

Status: ASSIGNED → RESOLVED
Closed: 3 years ago
status-firefox91: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → 91 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: