1713906 - Tests skipped in 'dom/tests/browser/browser.ini' for new Fission platform triage

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, task, P2)

Description

[Andrew Halberstadt [:ahal]]

The following tests were disabled in dom/tests/browser/browser.ini due to new Fission platform triage:
browser_noopener.js
browser_navigate_replace_browsingcontext.js

Full diff:

--- a/dom/tests/browser/browser.ini
+++ b/dom/tests/browser/browser.ini
@@ -115,27 +115,31 @@ support-files =
   test_new_window_from_content_child.html
 [browser_unlinkable_about_page_can_load_module_scripts.js]
 support-files =
   file_load_module_script.html
   file_module_loaded.js
   file_module_loaded2.js
 [browser_xhr_sandbox.js]
 [browser_noopener.js]
-skip-if = verify && debug && (os == 'linux')
+skip-if =
+  verify && debug && (os == 'linux')
+  fission && os == "linux" && asan  # New platform triage
 support-files =
   test_noopener_source.html
   test_noopener_target.html
 [browser_noopener_null_uri.js]
 [browser_wakelock.js]
 [browser_keypressTelemetry.js]
 skip-if = webrender
 [browser_windowProxy_transplant.js]
 support-files =
   file_postMessage_parent.html
 [browser_navigate_replace_browsingcontext.js]
+skip-if =
+  fission && os == "linux" && asan  # New platform triage
 [browser_persist_cross_origin_iframe.js]
 support-files =
   image.html
 [browser_bytecode_cache_asm_js.js]
 support-files =
   page_bytecode_cache_asm_js.html
   page_bytecode_cache_asm_js.js

See the following try push for failures:
https://treeherder.mozilla.org/jobs?repo=try&revision=ad7a18fdad3b8e35b44152c16d94babb80387cd8

To run these failures in your own try push, first revert the skip-if
annotations, then run:

$ ./mach try fuzzy --rebuild 3 dom/tests/browser/browser.ini

Then use the fuzzy interface to select the task(s) which are relevant to the
removed skip-if expression(s). Please note the failure may be intermittent
and/or been fixed since the triage took place.

Comment 1

[Chris Peterson [:cpeterson]]

We need to determine whether this browser-chrome test failure should block shipping Fission. Tracking for Fission Milestone M7a for the initial audit. Then we can decide whether to move this bug to Fission M8 or post-MVP (Fission Future).

Here is a recent Try run for Fission browser-chrome:

https://treeherder.mozilla.org/jobs?repo=try&revision=ad7a18fdad3b8e35b44152c16d94babb80387cd8

Comment 2

[Nika Layzell [:nika] (ni? for response)]

The navigate_replace_browsingcontext.js failure appears to be a null dereference in LSSnapshot::Finish() after the dom::Storage object is freed by the GC. (https://treeherder.mozilla.org/logviewer?job_id=341567156&repo=try&lineNumber=6063). There doesn't currently appear to be a browser_noopener.js failure in the linked try run, but there are retries in-flight.

ni? :asuth who might know who to ask about the LS crash.

Comment 4

[Neha Kochar [:neha]]

Quoting Jan's initial take on this:
"I suspect mActor to point to an actor that has been already freed by the CC before it is our turn. It might be also yet another case of “We need to look at our shutdown status more often” (though a raw pointer mActor reads bad in any case)."

Comment 5

[Neha Kochar [:neha]]

Jens confirmed that Jan will look into this, so assigning accordingly.

Comment 6

[Jan Varga [:janv]]

I can reproduce the null dereference in LSSnapshot::Finish() on try and I'm working on a fix.

Comment 7

[Jan Varga [:janv]]

Here's a log with extra debugging information about the flow during content process shutdown:
https://treeherder.mozilla.org/logviewer?job_id=343479554&repo=try&lineNumber=3312

Comment 8

[Jan Varga [:janv]]

Attachment: Bug 1713906 - Tests skipped in 'dom/tests/browser/browser.ini' for new Fission platform triage; r=jmaher

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e978f3c602a4
Tests skipped in 'dom/tests/browser/browser.ini' for new Fission platform triage; r=jmaher

Comment 10

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/e978f3c602a4