1713918 - UI does not always unlock when creating the first account

Status: RESOLVED FIXED

(Thunderbird :: Account Manager, defect, P1)

Description

[rsjtdrjgfuzkfg (Dirk Steinmetz)]

When creating a new account in a way other than completing the regular first-run flow, the folder panel is not displayed or remains empty.

I file this as a single bug for all account types, as I suspect a common cause. Still, all variants should be tested when verifying that this bug is resolved.

STR:
Thunderbird 89.0b4, clean profile (I tested on Linux x64, did not test other platforms)

• Variant A, create a feed account:
  1. Navigate to the start tab (for example by cancelling the email address setup)
  2. Pick the option to create a feed account in the start page
  3. Complete the wizard
• Variant B, create a news group account:
  1. Navigate to the start tab (for example by cancelling the email address setup)
  2. Pick the option to create a news group account in the start page
  3. Complete the wizard (dummy data is fine, just enter "a" or something in all mandatory fields!)
• Variant C, create an email account through the advanced settings:
  1. Enter any name and email address
  2. Click the manual configuration button in the bottom left
  3. Click the advanced settings link in the manual configuration area
  4. Confirm the message explaining that an account may be created from wrong data

Expected:
In the main/mail tab, the folder panel should become visible and contain "Local Folders" and the newly created account.

Actual:
In Variant A and C, the folder panel is still hidden and remains empty (even when made visible through the menu). In variant B, it becomes visible but also remains empty (the visibility status is broken, though: trying to hide it through the menu does not work the first time).

Restarting Thunderbird fixes the issue.

Comment 1

[Alessandro Castellani [:aleca]]

Attachment: Bug 1713918 - Reveal the folder pane UI when a new account is created outside the account setup tab. r=mkmelin

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/b61952684935
Reveal the folder pane UI when a new account is created outside the account setup tab. r=mkmelin

Comment 3

[Rob Lemley [:rjl]]

Comment on attachment 9224865 [details]
Bug 1713918 - Reveal the folder pane UI when a new account is created outside the account setup tab. r=mkmelin

[Approval Request Comment]
Regression caused by (bug #): 1697575
User impact if declined: There's no folders displayed if you go through manual account setup (which personally I do frequently when testing)
Testing completed (on c-c, etc.):
Risk to taking this patch (and alternatives if risky):

Comment 4

[Wayne Mery (:wsmwk)]

Comment on attachment 9224865 [details]
Bug 1713918 - Reveal the folder pane UI when a new account is created outside the account setup tab. r=mkmelin

[Triage Comment]
Approved for beta

Comment 5

[Rob Lemley [:rjl]]

Thunderbird 90.0b2:
https://hg.mozilla.org/releases/comm-beta/rev/6e3230ef81c3