1713920 - Scrolling bar is not visible after update to FF 89.0 on Linux (KDE + Oxygen GTK engine)

Status: RESOLVED FIXED

(Core :: Widget: Gtk, defect)

Description

[andrey.v.ponomarenko]

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:89.0) Gecko/20100101 Firefox/89.0

Steps to reproduce:

Installed latest version of Firefox 89.0 (64-bit) on CentOS-7. Vertical scrolling is visible only in black theme, but I don't like it. I like light themes.

Actual results:

Vertical scrolling is visible only in black theme.

Expected results:

Vertical scrolling is visible in light themes.

Comment 1

[andrey.v.ponomarenko]

UPDATE: seems that vertical scrolling is not visible in ALL themes. It's visible only on the Settings page, but not on real sites.

Comment 2

[BugBot [:suhaib / :marco]]

The Bugbug bot thinks this bug should belong to the 'Firefox::Theme' component, and is moving the bug to that component. Please revert this change in case you think the bot is wrong.

Comment 3

[andrey.v.ponomarenko]

Attachment: No scrolling on the right side of the page

Comment 4

[andrey.v.ponomarenko]

I have checked that this is Linux-specific issue. Ok on Windows.

Please fix ASAP because it's uncomfortable to work w/o the scrolling.

Comment 5

[andrey.v.ponomarenko]

Both vertical and horizontal bars are invisible.

Comment 6

[Timea Cernea [:tbabos][inactive]]

Hi,
There are some on-going and known issues for Linux scrollbars for which developers are looking into and already fixing some, such as Bug 1714103.
Can you please let us know which GTK theme are you using?

Comment 7

[Emilio Cobos Álvarez [:emilio]]

Yeah, this looks like bug 1714103, though info from the GTK theme would still be useful.

Comment 8

[andrey.v.ponomarenko]

GTK theme? I use KDE.

Comment 9

[Martin Stránský [:stransky] (ni? me)]

(In reply to andrey.v.ponomarenko from comment #8)

GTK theme? I use KDE.

Gtk themes are used even under KDE, Firfox does not have native KDe support.

Comment 10

[andrey.v.ponomarenko]

(In reply to Timea Cernea [:tbabos] from comment #6)

Can you please let us know which GTK theme are you using?

How to identify it?

Comment 11

[Martin Stránský [:stransky] (ni? me)]

Run gnome-tweaks application, go to 'Appearance' tab and check 'Applications' combobox.

Comment 12

[andrey.v.ponomarenko]

gnome-tweaks is not installed and requires a lot of packages to be installed in the system. Is where a simpler way to detect the theme?

Comment 13

[Emilio Cobos Álvarez [:emilio]]

Can you go to https://nightly.mozilla.org, then download and extract it somewhere, then run MOZ_LOG=Widget:5 ./firefox? that should log your gtk theme. And also that build should show scrollbars, so if you can confirm that it'd be great.

Comment 14

[andrey.v.ponomarenko]

Attachment: Firefox 91 log

Probably this line:

[Parent 13693: Main Thread]: D/Widget System Theme: oxygen-gtk. Alt Theme: oxygen-gtk

Comment 15

[andrey.v.ponomarenko]

(In reply to Emilio Cobos Álvarez (:emilio) from comment #13)

And also that build should show scrollbars, so if you can confirm that it'd be great.

I've downloaded nightly build, but scrolling is still not shown in this version. See screenshot. I don't see any changes comparing with my current 89 version.

Comment 16

[andrey.v.ponomarenko]

Attachment: FF 91 nightly - the issue still persists.

Comment 17

[andrey.v.ponomarenko]

But looks like this build is from May, 31. The bug has been reported later.

Comment 18

[Emilio Cobos Álvarez [:emilio]]

Ok it seems this has somehow a different root cause from bug 1714103. Reporter, which OS are you using? Oxygen is a gtk theme engine which doesn't work in recent gtk versions, so I'm going to need more specific info to repro this. Thanks.

Comment 19

[andrey.v.ponomarenko]

(In reply to Emilio Cobos Álvarez (:emilio) from comment #18)

Ok it seems this has somehow a different root cause from bug 1714103. Reporter, which OS are you using? Oxygen is a gtk theme engine which doesn't work in recent gtk versions, so I'm going to need more specific info to repro this. Thanks.

CentOS 7 / Fedora 21

Comment 20

[Emilio Cobos Álvarez [:emilio]]

Ok, I'll try to repro, thanks! I'm still surprised that bug 1714103 didn't fix it, though...

Comment 21

[Emilio Cobos Álvarez [:emilio]]

So I downloaded a centos 7 VM, installed KDE, confirmed that oxygen-gtk is being used, but still I do see the scroll thumb, both in FF 89 and Nightly. What other appearance settings do you have that could impact this?

Comment 22

[andrey.v.ponomarenko]

(In reply to Emilio Cobos Álvarez (:emilio) from comment #21)

So I downloaded a centos 7 VM, installed KDE, confirmed that oxygen-gtk is being used, but still I do see the scroll thumb, both in FF 89 and Nightly. What other appearance settings do you have that could impact this?

I use the system since 2011. This is not possible to remember all changes (if any). But I don't usually change anything in the appearance.

I can provide more diagnostics info if needed. What particular appearance settings you are interested in? I can make a screenshot or attach output of some command line.

And second question - why this depends on the system at all? What has changed and how does it now depend on the system?

Comment 23

[Emilio Cobos Álvarez [:emilio]]

(In reply to andrey.v.ponomarenko from comment #22)

(In reply to Emilio Cobos Álvarez (:emilio) from comment #21)

So I downloaded a centos 7 VM, installed KDE, confirmed that oxygen-gtk is being used, but still I do see the scroll thumb, both in FF 89 and Nightly. What other appearance settings do you have that could impact this?
I use the system since 2011. This is not possible to remember all changes (if any). But I don't usually change anything in the appearance.

I can provide more diagnostics info if needed. What particular appearance settings you are interested in? I can make a screenshot or attach output of some command line.

Hmm, the "GTK+ appearance" settings are the ones that should be relevant here. Also the configuration in /usr/share/themes/oxygen-gtk.

And second question - why this depends on the system at all? What has changed and how does it now depend on the system?

Firefox used to draw native scrollbars using GTK, but we stopped doing that for memory usage / performance. We still get some colors from the GTK theme so that the scrollbars look native, but apparently for your theme configuration we're apparently getting a transparent scrollbar thumb... But that should've been prevented by bug 1714103, so that's why I'm confused as for why that didn't fix it.

Can you try Nightly again, just in case (make sure to close other Firefox instances before, since it seems in comment 17 you were using an older build)? This build should definitely have the fix. If it's not fixed I'll try to land some logging that could help figuring out the root cause of this.

Comment 24

[andrey.v.ponomarenko]

(In reply to Emilio Cobos Álvarez (:emilio) from comment #23)

Can you try Nightly again, just in case (make sure to close other Firefox instances before, since it seems in comment 17 you were using an older build)? This build should definitely have the fix. If it's not fixed I'll try to land some logging that could help figuring out the root cause of this.

Sitll the same. Am I trying it properly?: 1) Extract, 2) Go to extracted firefox/ directory and 3) Click on the firefox binary?

Comment 25

[andrey.v.ponomarenko]

Attachment: FF 91 nightly - June 15, 2021 - the issue still persists

Comment 26

[andrey.v.ponomarenko]

Attachment: Compressed whole directory /usr/share/themes/oxygen-gtk

Comment 27

[andrey.v.ponomarenko]

(In reply to Emilio Cobos Álvarez (:emilio) from comment #23)

(In reply to andrey.v.ponomarenko from comment #22)

I can provide more diagnostics info if needed. What particular appearance settings you are interested in? I can make a screenshot or attach output of some command line.

Hmm, the "GTK+ appearance" settings are the ones that should be relevant here. Also the configuration in /usr/share/themes/oxygen-gtk.

Please see compressed directory /usr/share/themes/oxygen-gtk in the attachment.

BTW

Why not to let me choose color of scroll bar manually in the about:config?

Thank you.

Comment 28

[Emilio Cobos Álvarez [:emilio]]

Sitll the same. Am I trying it properly?: 1) Extract, 2) Go to extracted firefox/ directory and 3) Click on the firefox binary?

That should work if there's no other Firefox window open, yeah...

Ok, thanks for testing, I'll try to write some diagnostics and send a build your way to get more info. Is there anything interesting in ~/.config/gtk-3.0?

Comment 29

[Emilio Cobos Álvarez [:emilio]]

You should be able to change these via about:config btw: ui.themedScrollbarThumb* are string prefs that take css colors: https://searchfox.org/mozilla-central/source/widget/nsXPLookAndFeel.cpp#227

Comment 30

[andrey.v.ponomarenko]

(In reply to Emilio Cobos Álvarez (:emilio) from comment #28)

Ok, thanks for testing, I'll try to write some diagnostics and send a build your way to get more info. Is there anything interesting in ~/.config/gtk-3.0?

There is only one file in this directory:

]$ cat ~/.config/gtk-3.0/bookmarks 
file:///home/andrey/Downloads

Comment 31

[andrey.v.ponomarenko]

(In reply to Emilio Cobos Álvarez (:emilio) from comment #29)

You should be able to change these via about:config btw: ui.themedScrollbarThumb* are string prefs that take css colors: https://searchfox.org/mozilla-central/source/widget/nsXPLookAndFeel.cpp#227

I've set:

ui.themedScrollbarThumbActive=Gray
ui.themedScrollbarThumb=Gray
ui.themedScrollbarThumbHover=Gray

And now I'm able to work again.

Thanks a lot!

Comment 32

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1713920 - Add some logging for native GTK colors. r=stransky

Let's see if that allows us to figure out what's going on here.

Comment 33

[Emilio Cobos Álvarez [:emilio]]

After the patch above lands (I'd give you a link for a try build but try is borked today), a log running nightly with MOZ_LOG=LookAndFeel:5 should shed some light into what's going on.

Comment 34

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/276598b28566
Add some logging for native GTK colors. r=stransky

Comment 35

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/276598b28566

Comment 36

[andrey.v.ponomarenko]

What should I do to collect necessary logs?

Comment 37

[Emilio Cobos Álvarez [:emilio]]

MOZ_LOG=LookAndFeel:5 /path/to/nightly/firefox should do

Comment 38

[andrey.v.ponomarenko]

Attachment: Output of MOZ_LOG=LookAndFeel:5 /path/to/nightly/firefox

Comment 40

[Emilio Cobos Álvarez [:emilio]]

Sorry this fell through the cracks. From the log above, it seems all your scrollbar colors are getting computed as the same (#d6d2d0):

[Parent 6796: Main Thread]: D/LookAndFeel  * color 29: pref=ui.themedScrollbar success=1 value=ffd0d2d6
[Parent 6796: Main Thread]: D/LookAndFeel  * color 30: pref=ui.themedScrollbarInactive success=1 value=ffd0d2d6
[Parent 6796: Main Thread]: D/LookAndFeel  * color 31: pref=ui.themedScrollbarThumb success=1 value=ffd0d2d6
[Parent 6796: Main Thread]: D/LookAndFeel  * color 32: pref=ui.themedScrollbarThumbHover success=1 value=ffd0d2d6
[Parent 6796: Main Thread]: D/LookAndFeel  * color 33: pref=ui.themedScrollbarThumbActive success=1 value=ffd0d2d6
[Parent 6796: Main Thread]: D/LookAndFeel  * color 34: pref=ui.themedScrollbarThumbInactive success=1 value=ffd0d2d6

You can customize those prefs as strings to work around it, but I'll land a fix on our side as well.

Comment 41

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1713920 - Fall back to non-native colors if thumb and track are the same opaque color. r=stransky

Comment 42

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/86e3af1cf171
Fall back to non-native colors if thumb and track are the same opaque color. r=stransky

Comment 43

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/86e3af1cf171