1713944 - Pocket home panel links don't work if you click the icons

Status: VERIFIED FIXED

(Firefox :: Pocket, defect)

Description

[Scott [:thecount] Downe]

This is present in the my list and topic links, either the hamburger icon of the arrow icons are no longer clickable.

Steps to test:

1. Log into Pocket.
2. Go to a newtab.
3. Click the Pocket button.
4. Click the My list hamburger icon.

Expected: Should open your my list.
Actual: It only work if you click around the icon of the "My list" text.

Comment 1

[Scott [:thecount] Downe]

[Tracking Requested - why for this release]: User experience issues for a user that is trying to get to their list, and clicks on the icon, cannot get to their list. They are likely not going to be aware that that the rest of the link is clickable, and might just think it's broken, giving up.

Comment 2

[Julien Cristau [:jcristau]]

Please do leave a comment when requesting tracking, explaining why.

Comment 3

[Scott [:thecount] Downe]

Updated original comment with the reason. Thanks for catching that. I always forget that updating tracking also adds a comment.

Comment 4

[Scott [:thecount] Downe]

Attachment: Bug 1713944 - Fixing Pocket button home panel click events

Comment 5

[Julien Cristau [:jcristau]]

Thanks Scott :)

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cacbe22051d8
Fixing Pocket button home panel click events r=gvn

Comment 7

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/cacbe22051d8

Comment 8

[Scott [:thecount] Downe]

Comment on attachment 9224763 [details]
Bug 1713944 - Fixing Pocket button home panel click events

Beta/Release Uplift Approval Request

• User impact if declined: User experience issues for a user that is trying to get to their list, and clicks on the icon, cannot get to their list. They are likely not going to be aware that that the rest of the link is clickable, and might just think it's broken, giving up.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: Steps to test:

1. Log into Pocket.
2. Go to a newtab.
3. Click the Pocket button.
4. Click the My list hamburger icon.

• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Just 4 lines of fairly trivial js
• String changes made/needed: None

Comment 9

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9224763 [details]
Bug 1713944 - Fixing Pocket button home panel click events

Approved for 90.0b4.

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/4b9854213faf

Comment 11

[Robert Martin [:romartin], Ecosystem QA]

I have verified that the issue is no longer reproducible using the steps provided in comment 8 with Firefox Beta 90.0b4 (Build ID: 20210606185718) and Firefox Nightly 91.0a1 (20210606214208) on Windows 10 x64, macOS 11.3.1, and Ubuntu Linux 20.04 x64.

I've done the verification with both a premium Pocket account and a standard Pocket account.