Closed Bug 1713987 Opened 3 years ago Closed 3 years ago

[wpt-sync] Sync PR 29178 - Forced accent-color when it's a system color

Categories

(Testing :: web-platform-tests, task, P4)

task

Tracking

(firefox91 fixed)

RESOLVED FIXED
91 Branch
Tracking Status
firefox91 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 29178 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/29178
Details from upstream follow.

b'Alison Maher <almaher@microsoft.com>' wrote:

Forced accent-color when it's a system color

Accent-color shouldn't be forced if it is already a system color.
In order to accomplish this, StyleAutoColor also needed to store
the system color keyword in such cases, similarly to what was done for
StyleColor in CL:2373268.

This is a followup to CL:2909975.

Bug: 1092093
Change-Id: I28ab062c769baeac3cbe60eb5e8620663a9cb007
Reviewed-on: https://chromium-review.googlesource.com/2930842
WPT-Export-Revision: ea7f129827c54a2bb748a94b21908725f47ce4e5

CI Results

Ran 15 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 2 tests and 1 subtests

Status Summary

Firefox

OK : 2
FAIL: 10

Chrome

OK : 2
FAIL: 10

Safari

OK : 2
PASS: 1
FAIL: 9

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/forced-colors-mode/forced-colors-mode-41.html
Forced colors affects the resolved value of accent-color: FAIL (Chrome: FAIL, Safari: PASS)
Forced colors affects the resolved value of background-color: FAIL (Chrome: FAIL, Safari: FAIL)
Forced colors affects the resolved value of border-bottom-color: FAIL (Chrome: FAIL, Safari: FAIL)
Forced colors affects the resolved value of border-left-color: FAIL (Chrome: FAIL, Safari: FAIL)
Forced colors affects the resolved value of border-right-color: FAIL (Chrome: FAIL, Safari: FAIL)
Forced colors affects the resolved value of border-top-color: FAIL (Chrome: FAIL, Safari: FAIL)
Forced colors affects the resolved value of caret-color: FAIL (Chrome: FAIL, Safari: FAIL)
Forced colors affects the resolved value of color: FAIL (Chrome: FAIL, Safari: FAIL)
Forced colors affects the resolved value of outline-color: FAIL (Chrome: FAIL, Safari: FAIL)
/forced-colors-mode/forced-colors-mode-50.html
Accent-color computes to auto in forced colors mode, unless forced-color-adjust is none or accent-color is a system color.: FAIL (Chrome: FAIL, Safari: FAIL)

Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/f31011decbbf [wpt PR 29178] - Forced accent-color when it's a system color, a=testonly https://hg.mozilla.org/integration/autoland/rev/1867eed51bee [wpt PR 29178] - Update wpt metadata, a=testonly
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 91 Branch
You need to log in before you can comment on or make changes to this bug.