Closed
Bug 1714037
Opened 3 years ago
Closed 3 years ago
Move get/set/removeAttributeInBrowser test helpers from main shared-head to inspector shared-head
Categories
(DevTools :: Inspector, task, P3)
DevTools
Inspector
Tracking
(firefox91 fixed)
RESOLVED
FIXED
91 Branch
Tracking | Status | |
---|---|---|
firefox91 | --- | fixed |
People
(Reporter: jdescottes, Assigned: jdescottes)
References
Details
Attachments
(1 file)
From https://phabricator.services.mozilla.com/D116556#inline-647238
All call sites for those methods are in the inspector, and they always use the selected browser.
https://searchfox.org/mozilla-central/search?q=AttributeInBrowser&case=true&path=
We can align them to the APIs created in Bug 1714009:
- rename them from
setAttributeInBrowser
tosetContentPageElementAttribute
(etc...) - remove the browser argument
- move them from devtools/client/shared/test/shared-head.js to devtools/client/inspector/test/shared-head.js
Assignee | ||
Updated•3 years ago
|
Assignee: nobody → jdescottes
Status: NEW → ASSIGNED
Assignee | ||
Comment 1•3 years ago
|
||
Depends on D116557
Pushed by jdescottes@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/f20570353a09 [devtools] Move get/set/removeAttributeInBrowser test helpers from to inspector shared-head r=nchevobbe
Comment 3•3 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
status-firefox91:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 91 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•