Closed
Bug 171422
Opened 22 years ago
Closed 22 years ago
Missing return NULL statement in nssTrust_GetCERTCertTrustForCert, pki3hack.c
Categories
(NSS :: Libraries, defect, P1)
Tracking
(Not tracked)
RESOLVED
FIXED
3.6
People
(Reporter: wtc, Assigned: bugz)
Details
Attachments
(1 file)
|
576 bytes,
patch
|
bugz
:
review+
|
Details | Diff | Splinter Review |
In rev. 1.68 of pki3hack.c, function
nssTrust_GetCERTCertTrustForCert, line 515,
we have
515 if (!rvTrust) {
516 }
It seems that there should be a "return NULL;"
statement inside the body of 'if'.
|
Reporter | |
Comment 1•22 years ago
|
||
I found that 'rvTrust' cannot be NULL at that point. So perhaps the best fix is to delete the if statement altogether.
|
|
Reporter | |
Comment 2•22 years ago
|
||
|
|
Reporter | |
Updated•22 years ago
|
Severity: normal → trivial
Priority: -- → P1
Target Milestone: --- → 3.6
|
Assignee | |
Updated•22 years ago
|
Attachment #101010 -
Flags: review+
|
|
Reporter | |
Comment 3•22 years ago
|
||
Fix checked in.
Status: NEW → RESOLVED
Closed: 22 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•