1714248 - Change language used when removing a CardDAV address book

Status: RESOLVED FIXED

(Thunderbird :: Address Book, defect)

Description

[Geoff Lankow (:darktrojan)]

To remove a CardDAV book, you have to "Delete" it (should be "Unsubscribe" like a calendar) and you're asked "Are you sure you want to delete this address book and all of its contacts?" which you probably don't and that's not what happens anyway.

Comment 1

[Geoff Lankow (:darktrojan)]

Attachment: Bug 1714248 - Change language used when removing a CardDAV address book. r=mkmelin

This got messy.

I've added strings for the button and menu items to abMainWindow.dtd to avoid rewriting some complicated bits.
For the prompt messages I rewrote the whole thing in Fluent because I needed to do that for about:addressbook anyway.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/5240b6ddc228
Change language used when removing a CardDAV address book. r=mkmelin

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/77c736245fba
follow-up - Remove TODO comment that got TODONE. rs=me

Comment 4

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Is removeButton.tooltip unused because removeButton only gets used fo the context menu of the address book tree?

Comment 5

[Onno Ekker [:nONoNonO UTC+1]]

This doesn't seem to work in Thunderbird 91.
I now get an error when trying to remove an LDAP Directory Server:

Uncaught (in promise) TypeError: document.l10n is null
AbDeleteDirectory chrome://messenger/content/addressbook/abCommon.js:404

I tried with both default en-US and nl language pack, but both fail with the same error.

Comment 6

[Onno Ekker [:nONoNonO UTC+1]]

Attachment: Screenshot

Correction: this does work when you remove an address book from the Address Book window, but it fails when you try to remove the address book from the Global Addressing Preferences.