1714299 - Correct ORB's opaque response implementation

Status: RESOLVED FIXED

(Core :: DOM: Networking, defect, P2)

Description

[Anne (:annevk)]

As discussed offline the telemetry for ORB is somewhat off due to incorrectly identifying opaque responses. We should correct this and then observe if the telemetry becomes more in line with what would be expected.

In particular, an opaque response depends on request's mode (has to be "no-cors"), and depends on whether there was ever a cross-origin response to the request (i.e., a redirect chain of A -> B -> A results in an opaque response).

Comment 1

[Eden Chuang[:edenchuang]]

Attachment: Bug 1714299 - Correct the opaque response judgment for opaque response blocking.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5e9693e4d6b7
Correct the opaque response judgment for opaque response blocking. r=necko-reviewers,annevk,dragana

Comment 3

[Natalia Csoregi [:nataliaCs]]

Backed out for causing high frequency failures on browser_opaque_response_blocking_telemetry.js

• backout: https://hg.mozilla.org/integration/autoland/rev/a1d7eb08b69621ad798af9e3f37c26be430a1cef

• push: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&revision=5e9693e4d6b70feb7a325ceba9a68fd23bfba271

• range: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&fromchange=5e9693e4d6b70feb7a325ceba9a68fd23bfba271&test_paths=netwerk%2Ftest%2Fbrowser%2Fbrowser.ini&tochange=061e0d33541e1b95670f53c8994e8c9639c165d9

• failure log: https://treeherder.mozilla.org/logviewer?job_id=343485993&repo=autoland&lineNumber=5893

[task 2021-06-22T14:55:01.998Z] 14:55:01     INFO - TEST-PASS | netwerk/test/browser/browser_opaque_response_blocking_telemetry.js | Should not have recorded key Allowed_SniffAsImageOrAudioOrVideo - 
[task 2021-06-22T14:55:01.999Z] 14:55:01     INFO - Fetching cross-origin url: https://example.com/browser/netwerk/test/browser//res_object.html.
[task 2021-06-22T14:55:01.999Z] 14:55:01     INFO - Validating if the telemetry probe has been reported.
[task 2021-06-22T14:55:02.000Z] 14:55:01     INFO - Buffered messages finished
[task 2021-06-22T14:55:02.001Z] 14:55:02     INFO - TEST-UNEXPECTED-FAIL | netwerk/test/browser/browser_opaque_response_blocking_telemetry.js | Should not have recorded key Allowed_SniffAsImageOrAudioOrVideo - 
[task 2021-06-22T14:55:02.001Z] 14:55:02     INFO - Stack trace:
[task 2021-06-22T14:55:02.001Z] 14:55:02     INFO - chrome://mochikit/content/browser-test.js:test_ok:1331
[task 2021-06-22T14:55:02.001Z] 14:55:02     INFO - chrome://mochitests/content/browser/netwerk/test/browser/browser_opaque_response_blocking_telemetry.js:null:225
[task 2021-06-22T14:55:02.216Z] 14:55:02     INFO - Fetching cross-origin url: https://example.org/browser/netwerk/test/browser/res_img.png.
[task 2021-06-22T14:55:02.241Z] 14:55:02     INFO - Validating if the telemetry probe has been reported.
[task 2021-06-22T14:55:02.242Z] 14:55:02     INFO - TEST-PASS | netwerk/test/browser/browser_opaque_response_blocking_telemetry.js | Should not have recorded key Allowed_SniffAsImageOrAudioOrVideo -

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f694fff24c46
Correct the opaque response judgment for opaque response blocking. r=necko-reviewers,annevk,dragana

Comment 5

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/f694fff24c46