171430 - Add popup whitelisting

Status: VERIFIED FIXED

(Firefox :: Settings UI, defect)

Description

[Asa Dotzler [:asa]]

not all but we should get some of it into Phoenix.

Comment 1

[Asa Dotzler [:asa]]

whitelist in particular.

Comment 2

[Blake Ross]

-> hyatt

Comment 3

[Brendan Eich [:brendan]]

There's a Phoenix FE bug here for sure, but why should each app have to reinvent
the back-end wheel if the BE can be XP and part of the DOM?  At least, the DOM
could provide an interface for embedding apps to implement that it calls through
to decide when to popup.  I think danm said dveditz was arguing for this kind of
conslidated back-end recently.

/be

Comment 4

[Blake Ross]

We haven't had a chance to look into this yet...but we weren't planning on
reinventing anything, just bringing the whitelist aspect of the Mozilla stuff to
the trunk.  Is that not possible?

Comment 5

[Alex Bishop]

> We haven't had a chance to look into this yet...but we weren't planning on
> reinventing anything, just bringing the whitelist aspect of the Mozilla stuff 
> to the trunk.  Is that not possible?

According to bug 166442 comment 87 (paragraph starting "Whitelist request..."), 
it isn't. Unless I'm misunderstanding, Mozilla's pop-up blocking backend 
doesn't support whitelisting.

Comment 6

[Dan M]

  All Mozilla's popup blocking back end and nearly all the UI is in
extensions/cookie. I don't know your plans for including that in Phoenix. Best I
think would be to factor the back end part into a permissions library -- I keep
thinking modules/libperm -- which could be shared by everyone. The UI would stay
in the cookies extension. This hasn't been done, and I'm not even sure it's
acceptable to everyone.
  Mozilla's actual blocking of popups currently happens in application-level
code (xpfe/bootstrap). dveditz (and I) have noticed that it'd be one less thing
for other applications to do if it were in DOM-level code, alongside the current
window-opening script pref. Then Phoenix, for instance, would only have to
implement a prefs UI. I think this would best be done after factoring the back
end out of cookies, but a simpler hack job could also be done without going to
all that trouble.
  Part of teaching Phoenix, Mozilla, or anyone, whitelist popup blocking would
be tweaking cookies' permission manager to get full whitelist support.

Comment 7

[Asa Dotzler [:asa]]

fixed. if we want more or better we can do it under another bug. 

Comment 8

[Sylvain]

I installed Phoenix, but I don't like it that you're working with a whitelist
now.  I like it more the way it was in Mozilla, with a blacklist.

Wouldn't a combination be better?  A possibility to turn popup blocking on or
off, but with a higher priority for the white- and blacklists?  So that if you
have blocking disabled, you still don't see the popups on the blacklists (except
if you disable the blacklist).

Comment 9

[Simon Paquet [:sipaq]]

verified.