1714351 - Remove and reconcile -moz-proton-doorhangers media queries

Status: RESOLVED FIXED

(Firefox :: General, task)

Description

[:Gijs (he/him)]

There are quite a few of these: https://searchfox.org/mozilla-central/search?q=-moz-proton-doorhangers&path=css&case=false&regexp=false

It should be straightforward to remove the media queries and merge the -moz-proton-doorhangers styles with adjacent selectors where applicable, and remove the not -moz-proton-doorhangers ones completely.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Core::Audio/Video: Playback' component, and is moving the bug to that component. Please revert this change in case you think the bot is wrong.

Comment 2

[Michelle Goossens [:masterwayz]]

Attachment: Bug 1714351 - Remove and reconcile -moz-proton-doorhangers media queries r=emalysz

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/03a717a6815e
Remove and reconcile -moz-proton-doorhangers media queries r=emalysz

Comment 4

[Cristian Brindusan [:cbrindusan]]

Backed out changeset 03a717a6815e (Bug 1714351) for causing bc failures in browser_all_files_referenced.js.
https://hg.mozilla.org/integration/autoland/rev/5997efed0ece60bb9f35ce0f7b4b29203e70e5ba

Push with failures:
https://treeherder.mozilla.org/jobs?repo=autoland&revision=03a717a6815e47e82f4499233421e018e6a8ed9d&selectedTaskRun=G4Pu5X6PTRKME2g8RomWkQ.0

Failure log:
https://treeherder.mozilla.org/logviewer?job_id=341832709&repo=autoland&lineNumber=2940

Comment 5

[Michelle Goossens [:masterwayz]]

Will look into this today with emalysz her help. Leaving NI in place so I don't forget.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/63a0022d3535
Remove and reconcile -moz-proton-doorhangers media queries r=emalysz

Comment 7

[Michelle Goossens [:masterwayz]]

Attachment: Bug 1714351 - Fix incorrect css syntax

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/abe5cbf9daec
Fix incorrect css syntax a=fix

Comment 9

[Michelle Goossens [:masterwayz]]

Attachment: Bug 1714351 - Remove css rule r=emalysz

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a99a7188d39e
Remove css rule r=emalysz

Comment 11

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/63a0022d3535
https://hg.mozilla.org/mozilla-central/rev/abe5cbf9daec

Comment 12

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/a99a7188d39e