1714357 - Switch from `-moz-proton-contextmenus` and win10+default theme checks to a single media query

Status: RESOLVED FIXED

(Firefox :: Theme, task)

Description

[:Gijs (he/him)]

As per summary. This media query is a bit different from the other proton ones, in that it is always accompanied by other media queries that select for Windows 10 and the default theme (to avoid applying the styling in high contrast mode). Goals of this change:

• remove the proton context menu pref
• simplify the relevant media queries
• make changing decisions about whether to apply this styling easier to maintain (changing the implementation of the single media query, instead of updating N locations of CSS with convoluted media queries)
• maintain a way for win10 developers to easily check the non-win10 look&feel of the menu without spawning a separate win7/win8 VM (likely by flipping some other pref, perhaps under the ui.* namespace)

There are no other consumers of the pref left besides the existing media query and the CSS that uses it: https://searchfox.org/mozilla-central/search?q=proton.cont

Emilio, would you be interested in working on this?

Comment 1

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1714357 - Use a nicer media query for proton context menus. r=Gijs

Comment 2

[Emilio Cobos Álvarez (:emilio)]

Something like that should do :)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1ab906d9d30a
Use a nicer media query for proton context menus. r=Gijs

Comment 4

[Richard Marti (:Paenglab)]

Emilio, the menupopups are transparent with @media (-moz-windows-non-native-menus). Also the menulist menupopups are transparent.

You set them explicitly to transparent in your code.

Comment 5

[Richard Marti (:Paenglab)]

Found the issue: https://hg.mozilla.org/integration/autoland/rev/1ab906d9d30a#l6.14 you used -moz-proton-non-native-menus instead of -moz-windows-non-native-menus.

Comment 6

[Richard Marti (:Paenglab)]

https://hg.mozilla.org/integration/autoland/rev/1ab906d9d30a#l7.13 is also wrong.

Comment 7

[:Gijs (he/him)]

Attachment: Bug 1714357 - follow-up: fix media queries that accidentally used -moz-proton-non-native-menus, r?Paenglab

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6cd24cb7b151
Fix some typos.

Comment 9

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/1ab906d9d30a
https://hg.mozilla.org/mozilla-central/rev/6cd24cb7b151