1714417 - When dragging a tab from another window or dragging text, and trying to insert it as the rightmost tab it instead indicates it wants to insert as the leftmost tab if you have any hidden tabs.

Status: NEW

(Firefox :: Tabbed Browser, defect)

Description

[-_-]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:89.0) Gecko/20100101 Firefox/89.0

Steps to reproduce:

I can reproduce by following these steps:

1. Hide a tab (I use Tab Stash for this)
2. Try to drag a tab from another window (or text/image from any page) to the right of all open, non-hidden tabs.

Actual results:

The drop indicator indicates that the dragged item will be inserted in the leftmost position.
It actually drops it in the correct position anyway

(It seems like it stops being broken if enough tabs are open. During testing it seems to work fine once enough tabs are open to fill out the tab bar.)

Expected results:

The indicator should correctly show the dragged element as being inserted to the right of the rightmost tab.

Comment 1

[Andrei Purice]

Hey Mathisen,
I tried reproducing this issue on the latest versions of Firefox Nightly91.0a1 (2021-06-08), beta 90.0b5 and release 89.0 but the indicator shows the correct position and when I drop the tab it's alligned in the position it was dropped. Could you provide a video on this issue maybe I might be missing something?

Can you test the issue while in Safe Mode? You can find helpful info here : https://support.mozilla.org/en-US/kb/troubleshoot-firefox-issues-using-safe-mode .
Also a fresh new profile could help. You can find more about creating a new profile here : https://support.mozilla.org/en-US/kb/troubleshoot-and-diagnose-firefox-problems#w_6-create-a-new-firefox-profile .
If possible, you can test this issue on the nightly build as well. Download the build from : https://www.mozilla.org/en-US/firefox/nightly/all/ .

Comment 2

[-_-]

Attachment: Google — Mozilla Firefox 2021-06-09 13-18-42.mp4

Here is a video demonstrating the issue. Note that the tab preview and "List all tabs" context menu were not captured properly on the video. I try to demonstrate that there are a total of 4 tabs open in the end, where one of them is hidden.

Comment 3

[-_-]

Attachment: image.png

I'm unable to test the issue in troubleshoot mode, as there is no way to access the tab hiding functionality without an extension.
The issue is present if I create a new profile and install Tab Stash to hide a tab.
The issue is similarly present in the nightly version.

Further testing seems to indicate that if you hide the rightmost tab then it breaks 100%(indicates leftmost position instead of rightmost) until a new tab is created or inserted to the right.

If you hide any other tab, it works unless the point I'm dragging to happens to be on my leftmost monitor. In that case, if it's:

• To the left of the center of the rightmost tab - it indicates the correct position, though not highlighted since it is not relevant.
• [Green] To the right of the center of the rightmost tab, but still inside the rightmost tab - it indicates correctly, that it will insert in the rightmost position.
• [Red] To the right of the rightmost tab, fx. at the new tab button or further to the right - wrongly indicates it will insert in leftmost position.
• [Overlapping - Orange] In the area between the close tab button and the border of the righmost tab - indicator flickers rapidly between rightmost and leftmost position.

To clarify, if i stretch the window across 2 monitors in the above case, the indicator works correctly for any mouse position that is not over my leftmost monitor. The leftmost monitor happens to be to the left of the primary monitor, meaning it probably has negative coordinates, in case that matters.

Let me know if you need more details.

Comment 4

[Andrei Purice]

Setting a component for this issue in order to get the dev team involved.
If you feel it's an incorrect one please feel free to change it to a more appropriate one.

Comment 5

[Brindusa Tot, Desktop QA]

Tested on latested Nightly 104.0a1 (2022-07-04), on Windows 10.
If i used Tab Stash add-on to hide tabs, I can reproduce the issue for the first dragged item after hiding tabs and no other tabs are opened on the window: The drop indicator indicates that the dragged item will be inserted in the leftmost position, instead the rigth one. For the next dropped items the drop indicator is correct.