Closed Bug 1714466 Opened 3 years ago Closed 3 years ago

Relax upgrade dialog dependency on unrelated/deprecated prefs, e.g., whatsNewPanel and aboutwelcome

Categories

(Firefox :: Messaging System, enhancement, P1)

enhancement

Tracking

()

VERIFIED FIXED
91 Branch
Iteration:
91.2 - Jun 14 - Jun 27
Tracking Status
firefox89 --- wontfix
firefox90 --- wontfix
firefox91 --- verified

People

(Reporter: Mardak, Assigned: Mardak)

References

Details

(Whiteboard: [proton-onboarding])

Attachments

(1 file)

[Tracking Requested - why for this release]: ~1% of users didn't see the upgrade dialog in 89.0 but we can try again with relaxed checks if there's an 89.0.1

Bug 1697222 added various limitations for when the upgrade dialog should be shown and checked https://mozilla.slack.com/archives/G90HG2UQH/p1617999678019900

This includes browser.messaging-system.whatsNewPanel.enabled pref check for user previously unchecking "Notify about new features" from the whats new panel bug 1599138 as well as used by enterprise policy bug 1608240

This check has resulted in maybe 1% users (including Mikal) not seeing the MR1 upgrade dialog when upgrading to 89.0.

mkaply, is there a good way to differentiate user toggled pref vs policy? Maybe checking the locked status? Or should we just remove the pref checks as we do check Services.policies.isAllowed("postUpdateCustomPage") or some similar policies.isAllowed check?

https://searchfox.org/mozilla-central/rev/bf8d5de8528036c09590009720bc172882845b80/browser/components/enterprisepolicies/Policies.jsm#2084-2088

Another reasoning is that the upgrade dialog is sufficiently different from the whats new panel, so it shouldn't expand the pref usage anyway.

Ana, are there other trigger checks that should be removed/changed for potential uplift to 90 and/or 89?

Flags: needinfo?(mozilla)
Flags: needinfo?(amedinac)
Assignee: nobody → edilee
Status: NEW → ASSIGNED
Iteration: --- → 91.1 - May 31 - Jun 13
Priority: -- → P1

Ana, other checks include browser.aboutwelcome.enabled which SkipOnboarding policy changes https://searchfox.org/mozilla-central/rev/bf8d5de8528036c09590009720bc172882845b80/browser/components/enterprisepolicies/Policies.jsm#2108-2112

Not sure how many users would change that pref manually as there's no UI for it.

mkaply, although the condition is if ("SkipOnboarding") with no in param which seems like it turns it off for anyone using policies?
https://searchfox.org/mozilla-central/rev/bf8d5de8528036c09590009720bc172882845b80/browser/components/enterprisepolicies/Policies.jsm#2108-2112

(In reply to Ed Lee :Mardak from comment #1)

mkaply, although the condition is if ("SkipOnboarding") with no in param which seems like it turns it off for anyone using policies?
https://searchfox.org/mozilla-central/rev/bf8d5de8528036c09590009720bc172882845b80/browser/components/enterprisepolicies/Policies.jsm#2108-2112

Oh that should have been fixed with bug 1697566. Although the if condition is still confusing.

mkaply, how does that affect existing profiles that previously had the pref set to false before bug 1697566 fix? And like above for whatsNewPanel.enabled, if these have persisted, maybe we should not bother checking aboutwelcome.enabled for similar reasons?

Depends on: 1697566

While the mode is different, the general concept appears to be the same in that this replaces a "what's new" tab.

As one of the first to request this checkbox, I'd gently suggest that the [only] 1% of users who have chosen to turn off new feature notifications are far more likely than the other 99% to take exception to yet another "we want to pester you about stuff we did, or features we think you should use" - and maybe it'd be worth not poking them yet again. Wouldn't be so annoyed except that it was a lot of trouble just to get that option into the UI.

(Incidentally, references to "MR1" - major revision 1? - and the mysterious "proton" - the first Google link for "Firefox proton" being how to turn it off - and links to Figma and Jira which are inaccessible to the public also don't help in figuring out exactly what is being discussed in bugs. The latter in particular is annoying because it subverts a large part of the purpose of having a public bug DB.)

Yeah, I screwed up the SkipOnboarding thing twice. I need to fix it again.

I think just checking for ("browser.aboutwelcome.enabled", false) and locked should be enough to not show it to enterprises.

If some people see it accidentally, I don't think it's a big deal.

Flags: needinfo?(mozilla)

(In reply to Laurence "GreenReaper" Parry from comment #3)

While the mode is different, the general concept appears to be the same in that this replaces a "what's new" tab

To be clear, the what's new panel and icon have effectively been removed since 87 with bug 1691777 via bug 1694704, and separately the "what's new tab" is what got shown on a major upgrade, e.g., https://www.mozilla.org/firefox/88.0/whatsnew/ . I don't think users had a way to turn off that tab, so when the new upgrade dialog added extra dependencies/conditions on unrelated/deprecated "what's new panel" pref, it was as an extra courtesy especially for enterprise deployments, but potentially it was implemented too broadly.

The new feature does have a dedicated browser.startup.upgradeDialog.enabled to control as it's a different feature.

Depends on: 1694704
See Also: → 1691777
Summary: Relax trigger conditions for showing upgrade dialog, e.g., allow showing even if whats new panel was disabled → Relax upgrade dialog dependency on unrelated/deprecated prefs, e.g., whatsNewPanel and aboutwelcome
Iteration: 91.1 - May 31 - Jun 13 → 91.2 - Jun 14 - Jun 27

Yup Ana analyzed the data more and confirmed this isn't urgent for 89, so we'll do as mkaply sugggested in comment 4 to also check pref "locked" and try to uplift to 90.

Flags: needinfo?(amedinac)
See Also: → 1715997

Check default pref branch instead of user when looking for enterprise policy changes.

Pushed by elee@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/d13a7c599df0
Relax upgrade dialog dependency on unrelated/deprecated prefs, e.g., whatsNewPanel and aboutwelcome r=pdahiya
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 91 Branch

I have verified this enhancement using the steps from here and I can confirm that the following event is displayed in the "about:telemetry#events-tab" page: "category": upgrade_dialog, "method": trigger, "object": reason, "value": no-welcome.

Verified using the latest Firefox Nightly (91.0a1 Build ID - 20210624093849) installed on Windows 10 x64, macOS 10.15.7, and Linux Mint 20 x64.

Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: