Closed Bug 1714486 Opened 3 years ago Closed 3 years ago

Allow prefs to override Remote Settings config

Categories

(Firefox :: Security, defect, P1)

defect

Tracking

()

RESOLVED FIXED
91 Branch
Tracking Status
firefox90 --- verified
firefox91 --- fixed

People

(Reporter: nhnt11, Assigned: nhnt11)

References

Details

Attachments

(1 file)

This would allow us to use Normandy to ship urgent config changes. Currently Remote Settings values are respected over prefs, we should invert this.

Attachment #9225116 - Attachment description: Bug 1714486 - [DoH] Allow pref values to override Remote Settings. r=#necko!,Gijs! → Bug 1714486 - [DoH] Allow pref values to override Remote Settings. r=#necko!,johannh,jaws

[Tracking Requested - why for this release]:
We should make sure we can override remote settings with prefs when the new config system ships in 90 - just to be able to ship "chemspills".

Attachment #9225116 - Attachment description: Bug 1714486 - [DoH] Allow pref values to override Remote Settings. r=#necko!,johannh,jaws → Bug 1714486 - [DoH] Allow pref values to override Remote Settings. r=#necko!
Pushed by nhnt11@gmail.com: https://hg.mozilla.org/integration/autoland/rev/c824fe9b4adb [DoH] Allow pref values to override Remote Settings. r=necko-reviewers,jaws,dragana
Backout by csabou@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/a516d0598b2a Backed out 3 changesets (bug 1714486, bug 1713036) for xpcshell failures on test_trr.js. CLOSED TREE
Pushed by nhnt11@gmail.com: https://hg.mozilla.org/integration/autoland/rev/41800e77c675 [DoH] Allow pref values to override Remote Settings. r=necko-reviewers,jaws,dragana
Pushed by nhnt11@gmail.com: https://hg.mozilla.org/integration/autoland/rev/e74921a052f0 [DoH] Allow pref values to override Remote Settings. r=necko-reviewers,jaws,dragana
Flags: needinfo?(nhnt11)
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 91 Branch

Let's not uplift this.

Comment on attachment 9225116 [details]
Bug 1714486 - [DoH] Allow pref values to override Remote Settings. r=#necko!

Beta/Release Uplift Approval Request

  • User impact if declined: This uplift is in support of unblocking our rollout of DoH in Canada. The patches for which uplift is being requested update the DoH settings UI to work better with Remote Settings, and simplify the Normandy recipe for the rollout.
  • Is this code covered by automated tests?: Yes
  • Has the fix been verified in Nightly?: Yes
  • Needs manual test from QE?: No
  • If yes, steps to reproduce:
  • List of other uplifts needed: Bug 1713036, Bug 1720379, Bug 1718097, Bug 1719851, Bug 1714486
  • Risk to taking this patch: Medium
  • Why is the change risky/not risky? (and alternatives if risky): The changes have been baking for a while and work well. Medium risk because of the number of patches we need to uplift.
  • String changes made/needed:
Attachment #9225116 - Flags: approval-mozilla-release?

STR to verify this:

  1. On a new profile, set doh-rollout.home-region to US and restart Firefox
  2. Trigger a sync with Remote Settings, e.g. using the remote settings devtools addon as I described above. You will see services.settings.main.doh-config.last_check = <some large number which is a timestamp>, and also you will see doh-rollout.mode being set to 0 or 2 depending on the network.
  3. Now, set doh-rollout.us.enabled=false . Now, doh-rollout.mode value should go away, and also in about:preferences the checkbox for DoH should be unchecked.
  • We verified this issue across platforms (Windows 10 x64, Ubuntu 20 x64, macOS 11.4) on the 90.0.2 try-build provided by Nihanth, using the steps to reproduce from comment 13.

Comment on attachment 9225116 [details]
Bug 1714486 - [DoH] Allow pref values to override Remote Settings. r=#necko!

approved for 90.0.2

Attachment #9225116 - Flags: approval-mozilla-release? → approval-mozilla-release+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: