Allow prefs to override Remote Settings config
Categories
(Firefox :: Security, defect, P1)
Tracking
()
People
(Reporter: nhnt11, Assigned: nhnt11)
References
Details
Attachments
(1 file)
48 bytes,
text/x-phabricator-request
|
jcristau
:
approval-mozilla-release+
|
Details | Review |
This would allow us to use Normandy to ship urgent config changes. Currently Remote Settings values are respected over prefs, we should invert this.
Assignee | ||
Comment 1•3 years ago
|
||
Updated•3 years ago
|
Assignee | ||
Comment 2•3 years ago
|
||
[Tracking Requested - why for this release]:
We should make sure we can override remote settings with prefs when the new config system ships in 90 - just to be able to ship "chemspills".
Assignee | ||
Comment 3•3 years ago
|
||
Updated•3 years ago
|
Comment 6•3 years ago
|
||
Backed out for causing xpcshell and browser chrome failures.
Failure logs:
https://treeherder.mozilla.org/logviewer?job_id=343577523&repo=autoland
https://treeherder.mozilla.org/logviewer?job_id=343577699&repo=autoland
Backout link: https://hg.mozilla.org/integration/autoland/rev/a516d0598b2ab9b2920d513bcdb8e7e8805666bc
Comment 8•3 years ago
|
||
Backed out 2 changesets (bug 1713036, bug 1714486) for XPCshell failures in netwerk/test/unit/test_trr.js. CLOSED TREE
Log:
https://treeherder.mozilla.org/logviewer?job_id=343649984&repo=autoland&lineNumber=4387
Push with failures:
https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&revision=06c40198b07487ade14e363a7e82a41df6c83cde
Backout:
https://hg.mozilla.org/integration/autoland/rev/997eb0fed0378b1c4ddd5b0eadf589c40e5e84a2
Assignee | ||
Updated•3 years ago
|
Comment 10•3 years ago
|
||
bugherder |
Assignee | ||
Comment 11•3 years ago
|
||
Let's not uplift this.
Assignee | ||
Comment 12•3 years ago
|
||
Comment on attachment 9225116 [details]
Bug 1714486 - [DoH] Allow pref values to override Remote Settings. r=#necko!
Beta/Release Uplift Approval Request
- User impact if declined: This uplift is in support of unblocking our rollout of DoH in Canada. The patches for which uplift is being requested update the DoH settings UI to work better with Remote Settings, and simplify the Normandy recipe for the rollout.
- Is this code covered by automated tests?: Yes
- Has the fix been verified in Nightly?: Yes
- Needs manual test from QE?: No
- If yes, steps to reproduce:
- List of other uplifts needed: Bug 1713036, Bug 1720379, Bug 1718097, Bug 1719851, Bug 1714486
- Risk to taking this patch: Medium
- Why is the change risky/not risky? (and alternatives if risky): The changes have been baking for a while and work well. Medium risk because of the number of patches we need to uplift.
- String changes made/needed:
Updated•3 years ago
|
Assignee | ||
Comment 13•3 years ago
•
|
||
STR to verify this:
- On a new profile, set
doh-rollout.home-region
toUS
and restart Firefox - Trigger a sync with Remote Settings, e.g. using the remote settings devtools addon as I described above. You will see
services.settings.main.doh-config.last_check
= <some large number which is a timestamp>, and also you will seedoh-rollout.mode
being set to0
or2
depending on the network. - Now, set
doh-rollout.us.enabled=false
. Now,doh-rollout.mode
value should go away, and also in about:preferences the checkbox for DoH should be unchecked.
Comment 14•3 years ago
|
||
- We verified this issue across platforms (Windows 10 x64, Ubuntu 20 x64, macOS 11.4) on the 90.0.2 try-build provided by Nihanth, using the steps to reproduce from comment 13.
Comment 15•3 years ago
|
||
Comment on attachment 9225116 [details]
Bug 1714486 - [DoH] Allow pref values to override Remote Settings. r=#necko!
approved for 90.0.2
Comment 16•3 years ago
|
||
bugherder uplift |
Updated•3 years ago
|
Description
•