Closed Bug 1714608 Opened 5 years ago Closed 5 years ago

Clean up partitionKey parsing and matching code

Categories

(Core :: Privacy: Anti-Tracking, task, P3)

task

Tracking

()

RESOLVED FIXED
91 Branch
Tracking Status
firefox91 --- fixed

People

(Reporter: emz, Assigned: emz)

References

Details

Attachments

(3 external files)

Bug 1714065 adds OriginAttributes::ParsePartitionKey which can parse the string representation of the partition key into its atomic fields scheme, base domain and port. It also adds a pattern matcher that supports matching individual partitionKey attributes.

Since OriginAttributes will provide a way to parse the partitionKey, we can remove these following helper methods:

For the OriginAttributesPattern matching we already expose ChromeUtils#originAttributesMatchPattern to script callers. However, we will need to add an additional scriptable interface method for partitionKey parsing.

Summary: Clean up partitionKey matching code → Clean up partitionKey parsing and matching code
Blocks: 1646215
Assignee: nobody → pbz
Status: NEW → ASSIGNED
Keywords: leave-open
Pushed by pzuhlcke@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/67ab2380add1 Use partitionKey pattern matcher in ClearDataService#hasBaseDomain. r=szabka
Pushed by pzuhlcke@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/edc4528a66ff Cleaned up partitionKey base domain helpers. r=timhuang
Keywords: leave-open
Pushed by pzuhlcke@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/e982bb4e3e84 Replace custom partitionKey parsing method in SiteDataManager with ChromeUtils helper. r=timhuang
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → 91 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: