1714639 - Tab modal print shows blank on parent process pages

Status: VERIFIED FIXED

(Toolkit :: Printing, defect)

Description

[Mark Striemer [:mstriemer]]

With the changes for the simplify page mode from bug 1666247, the tab modal print crashes on the about:sessionrestore page. There's a patch there to disable the dialog, but this should be investigated and fixed.

Comment 1

[Geoff Lankow (:darktrojan) [away until April 11]]

I'd bet this is because about:sessionrestore is a parent process page. Thunderbird is also now crashing when printing from the parent process. Please have a look soon, this is pretty important for us, and our one release for the year is just around the corner.

If this line runs, it crashes. I'll keep digging but you'll have a better idea than I do.

Comment 2

[Mark Striemer [:mstriemer]]

Emilio had a fix for this in bug 1718204 but it hasn't landed yet. Maybe that will help with Thunderbird?

Comment 3

[Richard Marti (:Paenglab)]

(In reply to Mark Striemer [:mstriemer] from comment #2)

Emilio had a fix for this in bug 1718204 but it hasn't landed yet. Maybe that will help with Thunderbird?

With this fix TB does no more crash. The print dialog appears but the "Preparing preview" isn't shown and the preview is empty.

Comment 4

[Mark Striemer [:mstriemer]]

Emilio, any idea why the preview might not be loading with the fix from bug 1718204?

Comment 5

[Geoff Lankow (:darktrojan) [away until April 11]]

I agree with Richard's assessment. The browser's there and visible (you can set the CSS background colour and that shows), but it's empty.

Comment 6

[clochrua]

On 92.0a1 (2021-07-13) (64-bit)
I agree with Comment 5:
a) if I rt-mouse on any email in the message list I get the PrinPreview pages, printer details are complete but the print preview frame is empty
b) open same email and file -> print makes TB crash.
Re Wayne's question in Thunderbird bug 1720397, seems to be same result on any mail I tried.

Comment 8

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1714639 - Don't call FrameLoader.printPreview in hidden frames. r=mstriemer,jfkthame

We need to be displayed when cloning into a same-process frame, so that
the preview code hooks up to the view tree correctly and the frame is
correctly painted.

This works for out-of-process frames, but mostly by chance.

Fortify the printPreview() API code to gracefully handle that case, and
remove the sessionrestore special-case which is not really special.

Comment 9

[Wayne Mery (:wsmwk)]

(in case it's not obvious) very much need an uplift to 91 beta

Comment 10

[Emilio Cobos Álvarez (:emilio)]

[Tracking Requested - why for this release]: Printing parent process pages crashes.

Comment 11

[Wayne Mery (:wsmwk)]

Thanks for setting tracking.

I don't know about Firefox, but this is a blocker for releasing TB91. (I hesitate to use that severity)

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f032f4d08cfd
Don't call FrameLoader.printPreview in hidden frames. r=mstriemer,jwatt

Comment 13

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/f032f4d08cfd

Comment 14

[Emilio Cobos Álvarez (:emilio)]

Comment on attachment 9231361 [details]
Bug 1714639 - Don't call FrameLoader.printPreview in hidden frames. r=mstriemer,jfkthame

Beta/Release Uplift Approval Request

• User impact if declined: Parent process pages show blank until print settings are changed at least once.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: comment 0
• List of other uplifts needed: none
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): relatively simple fix
• String changes made/needed: none

Comment 15

[Pascal Chevrel:pascalc]

Comment on attachment 9231361 [details]
Bug 1714639 - Don't call FrameLoader.printPreview in hidden frames. r=mstriemer,jfkthame

Approved for 91 beta 7 beta 8, thanks.

Comment 16

[Pascal Chevrel:pascalc]

https://hg.mozilla.org/releases/mozilla-beta/rev/d2fe9983d47e

Comment 19

[Anca Soncutean [:Anca], Desktop Release QA]

Reproduced both problems (the initial one with Fx 91.0b4, and the current one after a fix for 1718204 landed with Fx 91.0b5) on Windows 10. .
Verified fixed with Fx 92.0a1 (2021-07-26) and Fx 91.0b8 (treeherder build) on Windows 10, macOS 11.0, Ubuntu 18.04