Closed Bug 1714641 Opened 8 months ago Closed 7 months ago

Remove "python2" items from virtualenv_packages files.

Categories

(Firefox Build System :: General, task)

task

Tracking

(firefox91 fixed)

RESOLVED FIXED
91 Branch
Tracking Status
firefox91 --- fixed

People

(Reporter: mhentges, Assigned: mhentges)

References

(Blocks 1 open bug)

Details

Attachments

(13 files)

48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
No description provided.
Summary: Remove "python2" items from virtualenv_requirements files. → Remove "python2" items from virtualenv_packages files.
Assignee: nobody → mhentges
Status: NEW → ASSIGNED

Now that Mach requires Python 3, python3: items will always be
used and python2: items will never be needed.

Depends on D116484

The actions are no longer used, so we can delete the associated
logic.

Depends on D117059

We should only be using the Python3 "wptserve" library at this point.

Depends on D117060

It provides shutil.which(...), which has been part of shutil since
Python 3.3.

Depends on D117062

enum functionality has been part of Python since, well, Python 3.4.

Depends on D117063

concurrent.futures functionality has been part of Python since
Python 3.2.

Depends on D117065

Based on the docs and the code within pathlib2, it seems focus only
on backporting the main features of pathlib to be available for
Python 2. It does not provide features in newer Python versions
of pathlib (such as is_mount, new in Python 3.7). Therefore, it
doesn't provide anything that the standard library of Python 3
doesn't have.

Depends on D117068

os.scandir() functionality has been part of Python since
Python 3.5.

Depends on D117071

Attachment #9225705 - Attachment description: Bug 1714641: Remove unused "wptserve_py2" vendored library → Bug 1714641: Remove usages of vendored "wptserve_py2" library
Attachment #9225704 - Attachment description: Bug 1714641: Remove usages of vendored "wptserve_py2" library → Bug 1714641: Remove unused "wptserve_py2" vendored library
Attachment #9225708 - Attachment description: Bug 1714641: Remove unused "enum34" vendored library → Bug 1714641: Remove usages of vendored "enum34" library
Attachment #9225707 - Attachment description: Bug 1714641: Remove usages of vendored "enum34" library → Bug 1714641: Remove unused "enum34" vendored library
Attachment #9225711 - Attachment description: Bug 1714641: Remove unused "futures" vendored library → Bug 1714641: Remove usages of vendored "futures" library
Attachment #9225709 - Attachment description: Bug 1714641: Remove usages of vendored "futures" library → Bug 1714641: Remove unused "futures" vendored library
Attachment #9225714 - Attachment description: Bug 1714641: Remove unused "pathlib2" vendored library → Bug 1714641: Remove usages of vendored "pathlib2" library
Attachment #9225712 - Attachment description: Bug 1714641: Remove usages of vendored "pathlib2" library → Bug 1714641: Remove unused "pathlib2" vendored library
Attachment #9225706 - Attachment description: Bug 1714641: Remove "backports" vendored code → Bug 1714641: Remove usages of vendored "backports" code
Pushed by mhentges@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/9e22e73aa3b0
Replace `pythonX` items in virtualenv_packages r=ahal
https://hg.mozilla.org/integration/autoland/rev/d3aaa4e4d0d4
Remove `pythonX` actions from virtualenv config r=ahal
https://hg.mozilla.org/integration/autoland/rev/a95f01511ea4
Remove usages of vendored "wptserve_py2" library r=jgraham,ahal
https://hg.mozilla.org/integration/autoland/rev/fa5a46bb76ed
Remove unused "wptserve_py2" vendored library r=ahal
https://hg.mozilla.org/integration/autoland/rev/fe6e228cb831
Remove usages of vendored "backports" code r=ahal,perftest-reviewers
https://hg.mozilla.org/integration/autoland/rev/74b076e8344e
Remove unused "backports" vendored code r=ahal
https://hg.mozilla.org/integration/autoland/rev/3b70dd793566
Remove usages of vendored "enum34" library r=ahal
https://hg.mozilla.org/integration/autoland/rev/300e075b1f7d
Remove unused "enum34" vendored library r=ahal
https://hg.mozilla.org/integration/autoland/rev/d12538dcb9a7
Remove usages of vendored "futures" library r=ahal
https://hg.mozilla.org/integration/autoland/rev/b961783bc489
Remove unused "futures" vendored library r=ahal
https://hg.mozilla.org/integration/autoland/rev/d2982a60bf11
Remove usages of vendored "pathlib2" library r=ahal
https://hg.mozilla.org/integration/autoland/rev/474708084822
Remove unused "pathlib2" vendored library r=ahal
https://hg.mozilla.org/integration/autoland/rev/15b0af326505
Remove unused "scandir" vendored library r=ahal
You need to log in before you can comment on or make changes to this bug.