Closed
Bug 1714646
Opened 3 years ago
Closed 3 years ago
moz-phab submits to the wrong branch if you switch between branches in the same local repository
Categories
(Conduit :: moz-phab, defect, P2)
Conduit
moz-phab
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: mossop, Assigned: zeid)
Details
(Keywords: conduit-triaged)
Attachments
(1 file)
moz-phab uses .arcconfig to figure out which branch to submit to, but then caches the repository in .hg/.moz-phab_phid. If you subsequently switch to a different branch and .arcconfig points to the new one moz-phab will ignore that and still submit to whatever is cached in .hg/.moz-phab_phid.
|
Assignee | |
Updated•3 years ago
|
Assignee: nobody → zeid
|
|
Assignee | |
Comment 1•3 years ago
|
||
Possible solution here is to include the "callsign" in .moz-phab_phid, and check the callsign value against the one parsed from .arcconfig to determine if the cache should be invalidated.
|
|
Assignee | |
Updated•3 years ago
|
Keywords: conduit-triaged
Priority: -- → P3
|
|
Assignee | |
Updated•3 years ago
|
Priority: P3 → P2
|
|
Assignee | |
Comment 2•3 years ago
|
||
This change restructures the repo phid cache file in order to ensure
that the correct repo phid that matches the call sign is being fetched.
|
|
Assignee | |
Comment 3•3 years ago
|
||
This will be released in 1.0.0rc2.
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
|
|
Assignee | |
Updated•3 years ago
|
Summary: moz-phab submits to the wrong branch if you switch between branches in the same local repository. → moz-phab submits to the wrong branch if you switch between branches in the same local repository
You need to log in
before you can comment on or make changes to this bug.
Description
•