Closed Bug 1714735 Opened 3 years ago Closed 3 years ago

[wpt-sync] Sync PR 29197 - [GridNG] Do an additional pass when the min/max depends on block-size

Categories

(Core :: Layout: Grid, task, P4)

Product:
Core
Component:
Layout: Grid
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
91 Branch
Tracking Flags:
Tracking Status
firefox91 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(Blocks 1 open bug,
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 29197 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/29197
Details from upstream follow.

b'Ian Kilpatrick <ikilpatrick@chromium.org>' wrote:

[GridNG] Do an additional pass when the min/max depends on block-size

As above. Previously legacy grid wasn't applying this rule directly, but
if a grid was laid out twice, it'd use stale information to get the
"correct" result on the 2nd layout pass. This fixed NG by explicity
performing a 2nd pass. Added tests which quote the relevant part of the
specification.

Bug: 1045599, 1213878
Change-Id: Ia2e977356099642f3b6d1276bfcad0e201695541
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2936087
Commit-Queue: Ian Kilpatrick \<ikilpatrick@chromium.org>
Reviewed-by: Kurt Catti-Schmidt \<kschmi@microsoft.com>
Reviewed-by: Ethan Jimenez \<ethavar@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#889078}

Component: web-platform-tests → Layout: Grid
Product: Testing → Core

CI Results

Ran 15 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 3 tests

Status Summary

Firefox

FAIL: 3

Chrome

PASS: 1
FAIL: 2

Safari

PASS: 1
FAIL: 2

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/css/css-grid/grid-items/grid-item-inline-contribution-001.html: FAIL (Chrome: PASS, Safari: FAIL)
/css/css-grid/grid-items/grid-item-inline-contribution-002.tentative.html: FAIL (Chrome: FAIL, Safari: PASS)
/css/css-grid/grid-items/grid-item-inline-contribution-003.tentative.html: FAIL (Chrome: FAIL, Safari: FAIL)

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/c70d4fd33497
[wpt PR 29197] - [GridNG] Do an additional pass when the min/max depends on block-size, a=testonly
https://hg.mozilla.org/integration/autoland/rev/5cee56e8abbd
[wpt PR 29197] - Update wpt metadata, a=testonly

https://hg.mozilla.org/mozilla-central/rev/c70d4fd33497
https://hg.mozilla.org/mozilla-central/rev/5cee56e8abbd

Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox91: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 91 Branch
You need to log in before you can comment on or make changes to this bug.