Closed Bug 1714738 Opened 3 years ago Closed 3 years ago

[wpt-sync] Sync PR 29209 - Fix pseudo element iteration from A11y while detaching

Categories

(Testing :: web-platform-tests, task, P4)

task

Tracking

(firefox91 fixed)

RESOLVED FIXED
91 Branch
Tracking Status
firefox91 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 29209 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/29209
Details from upstream follow.

b'Daniel Libby <dlibby@microsoft.com>' wrote:

Fix pseudo element iteration from A11y while detaching

Ensure accessibility code doesn't iterate over pseudo element state that
is in an inconsistent state. As it stands today, the parent pointer from
generated elements is cleared while the parent still has a pointer to
the generated element. This change reorders the assignment.

R=aleventhal@chromium.org

Bug: 1205770
Change-Id: I66bd2a5608b61ed7233d9430fbde8c64dc9b2162
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2937313
Commit-Queue: Daniel Libby \<dlibby@microsoft.com>
Reviewed-by: Aaron Leventhal \<aleventhal@chromium.org>
Reviewed-by: Mason Freed \<masonf@chromium.org>
Cr-Commit-Position: refs/heads/master@{#889123}

CI Results

Ran 15 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests

Status Summary

Firefox

PASS: 1

Chrome

PASS: 1

Safari

PASS: 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/202ec870b7db [wpt PR 29209] - Fix pseudo element iteration from A11y while detaching, a=testonly
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 91 Branch
You need to log in before you can comment on or make changes to this bug.