171475 - Flag UI is confusing

Status: RESOLVED FIXED

(Bugzilla :: Attachments & Requests, defect, P3)

Description

[Joel Peshkin]

In the UI for setting up flags (editflagtypes.cgi), it is not clear that the
default if nothing is either specificically included or excluded is that
everything is excluded.  Since the drop-down fields look very inclusive by
default, this should either be explicitly stated in the text of the UI or else
the default when a new flag is created should be to make it included in all.

Also, the whole flags feature needs a serious doc update or a good explanation
in the UI.

Comment 1

[Myk Melez [:myk] [@mykmelez]]

Attachment: patch v1: defaults to all categories for new flag type

I think defaulting to all categories for a new flag type is reasonable.  Here's
a patch that does that.

Comment 2

[Joel Peshkin]

Comment on attachment 104755 [details] [diff] [review]
patch v1: defaults to all categories for new flag type

r=joel

Flags still needs a doc update

Comment 3

[Myk Melez [:myk] [@mykmelez]]

Checking in editflagtypes.cgi;
/cvsroot/mozilla/webtools/bugzilla/editflagtypes.cgi,v  <--  editflagtypes.cgi
new revision: 1.2; previous revision: 1.1
done

Reassigning to barnboy for the docs work.

Comment 4

[Myk Melez [:myk] [@mykmelez]]

This should go to the Documentation component and have its dependency dropped,
since it's "fixed" in terms of code.

Comment 5

[Dave Miller [:justdave]]

Matthew is still going to be around to help out, but Jake is taking over the
day-to-day front-line triage type stuff for Documentation

Comment 6

[Dave Miller [:justdave]]

*** Bug 191163 has been marked as a duplicate of this bug. ***

Comment 7

[Dave Miller [:justdave]]

Jake is leaving for a while (Reserve unit got called up), and we don't have a
new docs owner yet.  Anyone interested in helping out, please add
[e-mail] to your watch list in your email preferences in Bugzilla.

Comment 8

[Max Kanat-Alexander]

Um, as far as I can see, there isn't any flags documentation at all, now... I'll
write it, but I wanted to know if there's something I should be modifying, or if
I should just create it out of whole cloth.

Comment 9

[Vlad Dascalu]

> Um, as far as I can see, there isn't any flags documentation at all, now...

Yeah. Those are bugs 198019 and 198020.

Comment 10

[Daniel Wang]

per comment 9, this should be resolved as fixed

Comment 11

[Dave Miller [:justdave]]

Nothing in comment 9 says this is fixed...  those bugs are about documentation,
not better UI.

Comment 12

[Dave Miller [:justdave]]

OK, you're right.  I should read the whole bug. :)  Comment 4 is where it says
so though. :)