1714761 - [perma] comm/mail/test/browser/account/browser_accountTelemetry.js | A promise chain failed to handle a rejection: can't access property "noPassword", this.protocol is null - stack: get _passwordRequired@resource:///modules/imAccounts.jsm:621:12

Status: RESOLVED FIXED

(Chat Core :: IRC, defect, P5)

Description

[Treeherder Bug Filer]

Filed by: mkmelin [at] iki.fi
Parsed log: https://treeherder.mozilla.org/logviewer?job_id=341758687&repo=comm-central
Full log: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/Baekt82IS3yFjmeWGkxhVg/runs/0/artifacts/public/logs/live_backing.log

---

Comment 1

[Intermittent Failures Robot]

14 failures in 3065 pushes (0.005 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• comm-central: 14

Platform and build breakdown:

• linux64: 3
  • opt: 3
• linux64-shippable: 2
  • opt: 2
• macosx1015-64: 2
  • opt: 2
• windows7-32: 2
  • opt: 2
• windows10-64: 1
  • opt: 1
• windows7-32-shippable: 1
  • opt: 1
• windows10-64-shippable: 1
  • opt: 1
• macosx1015-64-shippable: 2
  • opt: 2

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1714761&startday=2021-05-31&endday=2021-06-06&tree=all

Comment 2

[Geoff Lankow (:darktrojan)]

This appears to be triggered by the creation of an IRC account in the test. I don't think any of our changes at the time caused it, and there's a big list of m-c changes.

Comment 3

[Martin Giger [:freaktechnik]]

This is most likely a race that we just started losing due to some timing change (or the logins getting initialized within the test context, thus the promise resolving?): https://searchfox.org/comm-central/rev/7893eeaf930fcc8923c0ca59d5ed4e3be455d5a5/chat/components/src/imAccounts.jsm#204

I guess the solution is to make sure the imAccount we create is initialized enough that it has a protocol.

Comment 4

[Martin Giger [:freaktechnik]]

I think I have a fix, though I'm slightly confused how the protocol can be intact at line 208 of imAccounts.jsm and then be destroyed at 220. I don't see anything that would let other code run in between those two lines.

Comment 5

[Martin Giger [:freaktechnik]]

Attachment: Bug 1714761 - Fix race in imAccount constructor between account destruction and login service. r=clokep

Also disables OTR for browser_accountTelemetry.js due to a race with key generation when the account is removed.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/9d4c932955c5
Fix race in imAccount constructor between account destruction and login service. r=clokep

Comment 7

[Intermittent Failures Robot]

16 failures in 722 pushes (0.022 failures/push) were associated with this bug yesterday.

Repository breakdown:

• comm-central: 16

Platform and build breakdown:

• windows10-64: 2
  • opt: 2
• macosx1015-64: 2
  • opt: 2
• linux64: 2
  • opt: 2
• windows7-32: 2
  • opt: 2
• linux64-shippable: 2
  • opt: 2
• windows7-32-shippable: 2
  • opt: 2
• macosx1015-64-shippable: 2
  • opt: 2
• windows10-64-shippable: 2
  • opt: 2

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1714761&startday=2021-06-08&endday=2021-06-08&tree=all

Comment 8

[Intermittent Failures Robot]

16 failures in 3502 pushes (0.005 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• comm-central: 16

Platform and build breakdown:

• windows10-64: 2
  • opt: 2
• macosx1015-64: 2
  • opt: 2
• linux64: 2
  • opt: 2
• windows7-32: 2
  • opt: 2
• linux64-shippable: 2
  • opt: 2
• windows7-32-shippable: 2
  • opt: 2
• macosx1015-64-shippable: 2
  • opt: 2
• windows10-64-shippable: 2
  • opt: 2

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1714761&startday=2021-06-07&endday=2021-06-13&tree=all