1714863 - Port Bug 696414 "Attached vCard throws error message last is undefined" to SeaMonkey

Status: RESOLVED FIXED

(SeaMonkey :: MailNews: Message Display, defect)

Description

[Frank-Rainer Grahl (:frg)]

While testing I stumbed over bug 696414 with a test message including vcards.
Fix is just a simple straight port.

Comment 1

[Frank-Rainer Grahl (:frg)]

Attachment: 1714863-vcard-2538.patch

Trivial change which could go into 2.53.8 final but also to 2.53.9. Toss a coin.

[Approval Request Comment]
Regression caused by (bug #): --
User impact if declined: Error in log but didn't see other fallout.
Testing completed (on m-c, etc.): 2.53.9b1 pre
Risk to taking this patch (and alternatives if risky): trivial
String changes made by this patch: --

Comment 2

[Ian Neal]

Comment on attachment 9225463 [details] [diff] [review]
1714863-vcard-2538.patch

>+++ b/suite/mailnews/content/msgHdrViewOverlay.js
>+    handleAttachment: function(contentType, url, displayName, uri,
>+                               isExternalAttachment)
>     {
>-      // presentation level change....don't show vcards as external attachments in the UI.
>-      // libmime already renders them inline.
>+      this.skipAttachment = true;
> 
>+      // Don't show vcards as external attachments in the UI. libmime already
>+      //renders them inline.
Nit: space between // and renders please (this was fixed in a whitespace clean up for TB).

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/111d2357ffad
Attached vCard throws error message last is undefined; r=IanN

Comment 4

[Frank-Rainer Grahl (:frg)]

https://gitlab.com/seamonkey-project/seamonkey-2.53-comm/-/commit/c54617105903fcdb52cb3eb4e12a8a700f4fed2c
Attached vCard throws error message last is undefined; r=IanN a=IanN