1714871 - New (Proton) Improve indeterminate download indicator progress icon

Status: UNCONFIRMED

(Firefox :: Theme, enhancement, P3)

Description

[rcandres]

User Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:89.0) Gecko/20100101 Firefox/89.0

Expected results:

The download progress feels unfinished. The circular progress bar doesn't fill in at the same rate at different angles and it's not really evident that it's a download, at least while it happens. There's just a mysterious circle there, if it's at a stage where it actually looks like a circle.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Firefox::Theme' component, and is moving the bug to that component. Please revert this change in case you think the bot is wrong.

Comment 2

[Clara Guerrero ( Need Info Brindusa Tot Please)]

Attachment: download2.webm

Comment 3

[Clara Guerrero ( Need Info Brindusa Tot Please)]

Hi,

I am attaching video of a download using https://file-examples.com/index.php/text-files-and-archives-download/ . I've tried on: windows 10 pro
91.0a1 (2021-06-07) (64-bit) Can you share a video of what it looks like on your end?

Does this issue occur in the latest nightly version of firefox? Here is a link from where you can download it: https://www.mozilla.org/en-US/firefox/channel/desktop/

Thanks for the report.
Best regards, Clara.

Comment 4

[rcandres]

It's specifically an issue with the progress. The video attached is too short to show the circle filling in.
This issue mainly belongs to my Ubuntu 15.6" laptop, since the icons are just plain smaller there for some reason. I'm using Windows for the Nightly build, however, since I suspect I'll start a dependency war if I try to install it against the one from my package manager.

The issue is that on the 90 degree marks (12, 3, 6, and 9 o'clock positions on the circle) and especially in Ubuntu, the angle doesn't quite look right and doesn't match the actual progress well.

Also, I think I found a new issue: Downloads without progress info (like large files from Google Drive) show a roughly 10% progress the entire time rather than any sort of "unknown" icon, and it makes it appear like the download got stuck.

Recordings incoming. It took me a while to collect them all...

Comment 5

[rcandres]

Attachment: Screencast 2021-06-07 11 46 50.mp4

Download progress unknown, Ubuntu

Comment 6

[rcandres]

Attachment: download prog known ubuntu.mp4

Comment 7

[rcandres]

Um, those won't play in my browser but VLC does work. Let me know if you can open those; it may be a side effect of how I cropped them.

Comment 8

[rcandres]

Attachment: Firefox Nightly Win, 3rd download is a progress unknown, breaks progress report.mkv

Comment 9

[rcandres]

Comment on attachment 9225652 [details]
Screencast 2021-06-07 11 46 50.mp4

I believe this was the unknown download progress from Google example

Comment 10

[rcandres]

Attachment: progress known win.mkv

Comment 11

[rcandres]

Attachment: progress unknown win.mkv

Comment 12

[rcandres]

My recording software could apparently not see the actual popup for the downloads "drawer" (or whatever the proper name is). Still, the circle doesn't fill in steadily as the download progresses (which is easier to see if the drawer works, see the Ubuntu videos) in all three versions tested (Firefox Ubuntu 89, Windows Firefox 89, and Windows Nightly). It is however more noticeable in my Ubuntu browser since the icons are for reasons unknown to me about 25% smaller and the pixelation on the circle is a bit worse. That detail does survive a complete refresh/config deletion of Firefox, by the way. All the icons including on the actual Desktop taskbar and dock are simply smaller there.

Comment 13

[rcandres]

New update:

The yellow dot for failed downloads hides mostly behind the progress circle. If the circle is to be kept, the method of indicating failed downloads should be made less ambiguous/hard to see.

Comment 14

[Clara Guerrero ( Need Info Brindusa Tot Please)]

Attachment: download(1).gif

Thanks for all the feedback, I still don't seem to be able to reproduce on my end. I've set the component for the dev team to take a look. Thanks for providing all the details.
Best,
Clara

Comment 15

[Sam Foster [:sfoster] (he/him)]

(In reply to rcandres from comment #4)

The issue is that on the 90 degree marks (12, 3, 6, and 9 o'clock positions on the circle) and especially in Ubuntu, the angle doesn't quite look right and doesn't match the actual progress well.

I wonder if this is a rendering problem with the actual conic-gradient. Can you check https://jsfiddle.net/sfoster/mth19gbk/ and see if you can reproduce? At small sizes, there aren't a lot of pixels to work with to draw those diagonals.

Also, I think I found a new issue: Downloads without progress info (like large files from Google Drive) show a roughly 10% progress the entire time rather than any sort of "unknown" icon, and it makes it appear like the download got stuck.

This is the expected behavior for indeterminate-progress downloads (downloads which have no Content-Length header). Can you file a separate issue for this if you think its a problem?

Comment 16

[rcandres]

If I set the size of the inner progress indicator to around 12px I see something similar happen. It's about the same size too.

Should I also break out the issues for the failed download dot as well as the indeterminate-progress one?

Comment 17

[Sam Foster [:sfoster] (he/him)]

(In reply to rcandres from comment #16)

If I set the size of the inner progress indicator to around 12px I see something similar happen. It's about the same size too.

I filed bug 1717934 to see if this is something that can be addressed at the graphics layer. My take - and please correct me if I've misunderstood - is that the pie-slice doesnt always accurately reflect progress because of the innaccuracy of how that angle/diagonal is rendered. At higher pixel densities the lines are smoother and sharper.

Should I also break out the issues for the failed download dot as well as the indeterminate-progress one?

Yes please. I wasn't able to find a bug on file for the failed download badge (dot) issue.

Comment 18

[rcandres]

(In reply to Sam Foster [:sfoster] (he/him) from comment #17)

(In reply to rcandres from comment #16)

If I set the size of the inner progress indicator to around 12px I see something similar happen. It's about the same size too.

I filed bug 1717934 to see if this is something that can be addressed at the graphics layer. My take - and please correct me if I've misunderstood - is that the pie-slice doesnt always accurately reflect progress because of the innaccuracy of how that angle/diagonal is rendered. At higher pixel densities the lines are smoother and sharper.

Yes, that is exactly what is happening. I'm sorry if I hadn't made that clear.

Should I also break out the issues for the failed download dot as well as the indeterminate-progress one?

Yes please. I wasn't able to find a bug on file for the failed download badge (dot) issue.

Alright, I will do that shortly.

Comment 19

[rcandres]

I was recently thinking of this due to thinking about animations for the indeterminate progress version, but is the pie graph shape still under consideration? An arc that turns into a hollow circle as it completes might be more clear than a pie, as the outer circumference of the shape will have more pixels for detail even in a smaller display.

Comment 20

[Clara Guerrero ( Need Info Brindusa Tot Please)]

Setting the Qa-not-actionable flag since this issue does not reproduce on our end.

Comment 21

[Sam Foster [:sfoster] (he/him)]

To re-summarize - this bug is a request for a better solution for indicating a indeterminate download. I.e. one where the server gives us no Content-Length and we can't calculate how much progress to show.