Closed Bug 1714954 Opened 3 years ago Closed 3 years ago

[wpt-sync] Sync PR 29245 - [TablesNG] Don't paint collapsed borders when visibility:hidden.

Categories

(Core :: Layout: Tables, task, P4)

task

Tracking

()

RESOLVED FIXED
91 Branch
Tracking Status
firefox91 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 29245 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/29245
Details from upstream follow.

b'Ian Kilpatrick <ikilpatrick@chromium.org>' wrote:

[TablesNG] Don't paint collapsed borders when visibility:hidden.

Previously we were unconditionally painting collapsed borders even if
we were hidden (and just trying to paint children).

This adds the "is_visible" check.

Bug: 1216308
Change-Id: Ia9223ab324c11d2eba5e75ab537cba2ddc722f2a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2939492
Reviewed-by: Xianzhu Wang \<wangxianzhu@chromium.org>
Owners-Override: Aleks Totic \<atotic@chromium.org>
Commit-Queue: Ian Kilpatrick \<ikilpatrick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#889536}

Component: web-platform-tests → Layout: Tables
Product: Testing → Core

CI Results

Ran 15 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests

Status Summary

Firefox

PASS: 1

Chrome

FAIL: 1

Safari

PASS: 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/7cff955a07c2
[wpt PR 29245] - [TablesNG] Don't paint collapsed borders when visibility:hidden., a=testonly
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 91 Branch
You need to log in before you can comment on or make changes to this bug.