Closed Bug 1715084 Opened 3 years ago Closed 5 months ago

Include the directory in LeakSanitizer output

Categories

(Testing :: General, task, P3)

Default
task

Tracking

(firefox120 fixed)

RESOLVED FIXED
120 Branch
Tracking Status
firefox120 --- fixed

People

(Reporter: mccr8, Assigned: jmaher)

References

(Blocks 2 open bugs)

Details

Attachments

(1 file)

As in bug 1715081, we should include the directory in LeakSanitizer failure output, to make it easier to classify different leaks.

Blocks: LSan

given: https://treeherder.mozilla.org/logviewer?job_id=431802319&repo=mozilla-central&lineNumber=14297

we have:
10:53:39 ERROR - TEST-UNEXPECTED-FAIL | LeakSanitizer | leak at ShrinkToFit, forget, gfxUserFontEntry::SanitizeOpenTypeData, gfxUserFontEntry::StartPlatformFontLoadOnBackgroundThread

if we add a directory, this would be:
10:53:39 ERROR - TEST-UNEXPECTED-FAIL | LeakSanitizer leak at ShrinkToFit, forget, gfxUserFontEntry::SanitizeOpenTypeData, gfxUserFontEntry::StartPlatformFontLoadOnBackgroundThread | <path>

let me build a try push with an example.

here is an example:
TEST-UNEXPECTED-FAIL | LeakSanitizer leak at mozilla::dom::workerinternals::, mozilla::dom::workerinternals::LoadMainScript, mozilla::dom::workerinternals::loader::WorkerScriptLoader::CreateScriptLoadRequest, mozilla::dom::workerinternals::loader::WorkerScriptLoader::CreateScriptRequests | dom/workers/test/mochitest.ini

(this is both sorted (bug 1765225 wip) and adds a path)

:mccr8, how does this look?

That looks reasonable. I'm not sure how much it'll help but it doesn't seem like it would hurt.

It does look like the script isn't probably dealing with the (anonymous namespace) in mozilla::dom::workerinternals::(anonymous namespace)::LoadAllScripts but I assume that's a preexisting issue with the regular expression matching the open paren. I haven't actually noticed that before so it isn't a big deal.

Assignee: nobody → jmaher
Status: NEW → ASSIGNED
Pushed by jmaher@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/a0eb9e2c8797
Add directory to LeakSanitizer output. r=mccr8
Status: ASSIGNED → RESOLVED
Closed: 5 months ago
Resolution: --- → FIXED
Target Milestone: --- → 120 Branch
You need to log in before you can comment on or make changes to this bug.