1715084 - Include the directory in LeakSanitizer output

Status: RESOLVED FIXED

(Testing :: General, task, P3)

Description

[Andrew McCreight [:mccr8]]

As in bug 1715081, we should include the directory in LeakSanitizer failure output, to make it easier to classify different leaks.

Comment 1

[Joel Maher ( :jmaher ) (UTC -8)]

given: https://treeherder.mozilla.org/logviewer?job_id=431802319&repo=mozilla-central&lineNumber=14297

we have:
10:53:39 ERROR - TEST-UNEXPECTED-FAIL | LeakSanitizer | leak at ShrinkToFit, forget, gfxUserFontEntry::SanitizeOpenTypeData, gfxUserFontEntry::StartPlatformFontLoadOnBackgroundThread

if we add a directory, this would be:
10:53:39 ERROR - TEST-UNEXPECTED-FAIL | LeakSanitizer leak at ShrinkToFit, forget, gfxUserFontEntry::SanitizeOpenTypeData, gfxUserFontEntry::StartPlatformFontLoadOnBackgroundThread | <path>

let me build a try push with an example.

Comment 2

[Joel Maher ( :jmaher ) (UTC -8)]

here is an example:
TEST-UNEXPECTED-FAIL | LeakSanitizer leak at mozilla::dom::workerinternals::, mozilla::dom::workerinternals::LoadMainScript, mozilla::dom::workerinternals::loader::WorkerScriptLoader::CreateScriptLoadRequest, mozilla::dom::workerinternals::loader::WorkerScriptLoader::CreateScriptRequests | dom/workers/test/mochitest.ini

(this is both sorted (bug 1765225 wip) and adds a path)

:mccr8, how does this look?

Comment 3

[Andrew McCreight [:mccr8]]

That looks reasonable. I'm not sure how much it'll help but it doesn't seem like it would hurt.

It does look like the script isn't probably dealing with the (anonymous namespace) in mozilla::dom::workerinternals::(anonymous namespace)::LoadAllScripts but I assume that's a preexisting issue with the regular expression matching the open paren. I haven't actually noticed that before so it isn't a big deal.

Comment 4

[Joel Maher ( :jmaher ) (UTC -8)]

Attachment: Bug 1715084 - Add directory to LeakSanitizer output. r=mccr8!

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a0eb9e2c8797
Add directory to LeakSanitizer output. r=mccr8

Comment 6

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/a0eb9e2c8797