Closed Bug 1715093 Opened 4 years ago Closed 4 years ago

[wpt-sync] Sync PR 29200 - Non-composited animations should not be considered as no-op animations

Categories

(Core :: CSS Transitions and Animations, task, P4)

task

Tracking

()

RESOLVED FIXED
91 Branch
Tracking Status
firefox91 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 29200 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/29200
Details from upstream follow.

b'Philip Rogers <pdr@chromium.org>' wrote:

Non-composited animations should not be considered as no-op animations

Animations that have ended are no longer composited and should not set
Animation::compositor_property_animations_have_no_effect_. This patch
avoids a DCHECK in CompositorPropertyAnimationsHaveNoEffect where not
all compositor properties were present due to there not being an active
compositor animation. This patch also improves the performance of
CompositorPropertyAnimationsHaveNoEffect by skipping more cases.

Bug: 1213307
Change-Id: Iced16460d0cb0e47b7f2def1f9a431389113586b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2935801
Auto-Submit: Philip Rogers \<pdr@chromium.org>
Reviewed-by: Robert Flack \<flackr@chromium.org>
Commit-Queue: Philip Rogers \<pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#889358}

Component: web-platform-tests → CSS Transitions and Animations
Product: Testing → Core

CI Results

Ran 15 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests

Status Summary

Firefox

PASS: 1

Chrome

PASS: 1

Safari

PASS: 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/8f338840cdd9 [wpt PR 29200] - Non-composited animations should not be considered as no-op animations, a=testonly
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → 91 Branch
You need to log in before you can comment on or make changes to this bug.