1715128 - Port bug 1698814: Clean up --lwt-toolbar-field-* variables after proton

Status: RESOLVED FIXED

(Thunderbird :: Upstream Synchronization, task)

Comment 1

[Richard Marti (:Paenglab)]

Attachment: 1715128-clean-up-lwt-toolbar-field-variables.patch

Bug 1698814 is not yet fully reviewed but we don't know how fast M-C is until their bug lands. I tested it with the M-C patches.

Comment 2

[Richard Marti (:Paenglab)]

Attachment: 1715128-clean-up-lwt-toolbar-field-variables.patch

Updated patch to better work with different combinations of system theme and TB theme.

The download tab has some issues which I address in a new bug.

Comment 3

[Richard Marti (:Paenglab)]

Attachment: 1715128-clean-up-lwt-toolbar-field-variables.patch

Updated patch to apply. No need to review now as the M-C bug has no review yet.

Comment 4

[Richard Marti (:Paenglab)]

Attachment: zielgerade

Comment 5

[Richard Marti (:Paenglab)]

Attachment: 1715128-clean-up-lwt-toolbar-field-variables.patch

Bug 1698814 is now on the home straight to land. We need to land it together when it merges to M-C because it changes a lot of variable names which will break the styling. If all goes well it will be probably in the next Daily.

Comment 6

[Richard Marti (:Paenglab)]

Bug 1698814 landed.

Comment 7

[Magnus Melin [:mkmelin]]

Comment on attachment 9234717 [details] [diff] [review]
1715128-clean-up-lwt-toolbar-field-variables.patch

Review of attachment 9234717 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks Richard! r=mkmelin

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/cd6a7b3ab3a4
Port bug 1698814: Clean up --lwt-toolbar-field-* variables after proton. r=mkmelin