Closed Bug 1715262 Opened 3 years ago Closed 2 years ago

We should encourage people to validate their metric/ping definition files even if they're not generating markdown

Categories

(Data Platform and Tools :: Glean Platform, task)

task

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: wlach, Unassigned)

Details

It looks like the first version of Mozilla VPN was committed with a TBD entry in pings.yaml:

https://github.com/mozilla-mobile/mozilla-vpn-client/commits/a18c121e738b57281d19c72273885014e9910dbf/glean/pings.yaml

This is a violation of the glean schema. We no longer have guidance that people need to generate markdown documentation, but there was an implicit validation step in doing so. We should encourage people to at least run the glean parser's validation step here.

I actually noticed I made the same mistake with mozregression when I removed the metrics.md generation step:

https://github.com/mozilla/mozregression/commit/fa18254ddfaaa78aebb513788e9e4799730cd362

This is now fixed by using the probe-scraper "push model". This was already rolled out to all Glean products, including mozregression.

Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.