1715267 - valgrind-test | Conditional jump or move depends on uninitialised value(s) at webrender::renderer::upload::upload_to_texture_cache

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, defect, P3)

Description

[Andrew Osmond [:aosmond] (he/him)]

[task 2021-06-08T00:11:02.675Z] 00:11:02     INFO -   3:57.09 ==12454== Thread 33 Renderer:
[task 2021-06-08T00:11:02.675Z] 00:11:02     INFO -   3:57.09 TEST-UNEXPECTED-FAIL | valgrind-test | Conditional jump or move depends on uninitialised value(s) at webrender::renderer::upload::upload_to_texture_cache / webrender::renderer::Renderer::update_texture_cache / webrender::renderer::Renderer::render_impl / wr_renderer_render
[task 2021-06-08T00:11:02.675Z] 00:11:02     INFO -   3:57.09 ==12454== Conditional jump or move depends on uninitialised value(s)
[task 2021-06-08T00:11:02.676Z] 00:11:02     INFO -   3:57.09 ==12454==    at 0x162B199F: webrender::renderer::upload::upload_to_texture_cache+10639 (mod.rs:2045)
[task 2021-06-08T00:11:02.676Z] 00:11:02     INFO -   3:57.09 ==12454==    by 0x162A7567: webrender::renderer::Renderer::update_texture_cache+5191 (mod.rs:2241)
[task 2021-06-08T00:11:02.676Z] 00:11:02     INFO -   3:57.09 ==12454==    by 0x1629EF2F: webrender::renderer::Renderer::render_impl+3647 (mod.rs:1874)
[task 2021-06-08T00:11:02.676Z] 00:11:02     INFO -   3:57.09 ==12454==    by 0x162F1F63: wr_renderer_render+979 (mod.rs:1660)
[task 2021-06-08T00:11:02.677Z] 00:11:02     INFO -   3:57.09 ==12454==    by 0x11EB2FD9: mozilla::wr::RendererOGL::UpdateAndRender(mozilla::Maybe<mozilla::gfx::IntSizeTyped<mozilla::gfx::UnknownUnits> > const&, mozilla::Maybe<mozilla::wr::ImageFormat> const&, mozilla::Maybe<mozilla::Range<unsigned char> > const&, bool*, mozilla::wr::RendererStats*)+361 (checkouts/gecko/gfx/webrender_bindings/RendererOGL.cpp:186)
[task 2021-06-08T00:11:02.677Z] 00:11:02     INFO -   3:57.09 ==12454==    by 0x11EB2603: mozilla::wr::RenderThread::UpdateAndRender(mozilla::wr::WrWindowId, mozilla::layers::BaseTransactionId<mozilla::VsyncIdType> const&, mozilla::TimeStamp const&, bool, mozilla::Maybe<mozilla::gfx::IntSizeTyped<mozilla::gfx::UnknownUnits> > const&, mozilla::Maybe<mozilla::wr::ImageFormat> const&, mozilla::Maybe<mozilla::Range<unsigned char> > const&, bool*)+595 (checkouts/gecko/gfx/webrender_bindings/RenderThread.cpp:485)
[task 2021-06-08T00:11:02.677Z] 00:11:02     INFO -   3:57.09 ==12454==    by 0x11EB220F: mozilla::wr::RenderThread::HandleFrameOneDoc(mozilla::wr::WrWindowId, bool)+687 (checkouts/gecko/gfx/webrender_bindings/RenderThread.cpp:340)
[task 2021-06-08T00:11:02.678Z] 00:11:02     INFO -   3:57.09 ==12454==    by 0x11EB8B1E: applyImpl<mozilla::wr::RenderThread, void (mozilla::wr::RenderThread::*)(mozilla::wr::WrWindowId, bool), StoreCopyPassByConstLRef<mozilla::wr::WrWindowId>, StoreCopyPassByConstLRef<bool> , 0, 1> (dist/include/nsThreadUtils.h:1150)
[task 2021-06-08T00:11:02.678Z] 00:11:02     INFO -   3:57.09 ==12454==    by 0x11EB8B1E: apply<mozilla::wr::RenderThread, void (mozilla::wr::RenderThread::*)(mozilla::wr::WrWindowId, bool)> (dist/include/nsThreadUtils.h:1156)
[task 2021-06-08T00:11:02.678Z] 00:11:02     INFO -   3:57.09 ==12454==    by 0x11EB8B1E: mozilla::detail::RunnableMethodImpl<mozilla::wr::RenderThread*, void (mozilla::wr::RenderThread::*)(mozilla::wr::WrWindowId, bool), true, (mozilla::RunnableKind)0, mozilla::wr::WrWindowId, bool>::Run()+46 (dist/include/nsThreadUtils.h:1203)
[task 2021-06-08T00:11:02.678Z] 00:11:02     INFO -   3:57.09 ==12454==    by 0x115B630D: MessageLoop::RunTask(already_AddRefed<nsIRunnable>)+189 (checkouts/gecko/ipc/chromium/src/base/message_loop.cc:468)
[task 2021-06-08T00:11:02.679Z] 00:11:02     INFO -   3:57.09 ==12454==    by 0x115B6DAB: DeferOrRunPendingTask (checkouts/gecko/ipc/chromium/src/base/message_loop.cc:477)
[task 2021-06-08T00:11:02.679Z] 00:11:02     INFO -   3:57.09 ==12454==    by 0x115B6DAB: MessageLoop::DoWork()+923 (checkouts/gecko/ipc/chromium/src/base/message_loop.cc:552)
[task 2021-06-08T00:11:02.679Z] 00:11:02     INFO -   3:57.09 ==12454==    by 0x115B7400: base::MessagePumpDefault::Run(base::MessagePump::Delegate*)+288 (checkouts/gecko/ipc/chromium/src/base/message_pump_default.cc:35)
[task 2021-06-08T00:11:02.679Z] 00:11:02     INFO -   3:57.09 ==12454==    by 0x115B6145: RunInternal (checkouts/gecko/ipc/chromium/src/base/message_loop.cc:335)
[task 2021-06-08T00:11:02.679Z] 00:11:02     INFO -   3:57.09 ==12454==    by 0x115B6145: RunHandler (checkouts/gecko/ipc/chromium/src/base/message_loop.cc:328)
[task 2021-06-08T00:11:02.680Z] 00:11:02     INFO -   3:57.09 ==12454==    by 0x115B6145: MessageLoop::Run()+85 (checkouts/gecko/ipc/chromium/src/base/message_loop.cc:310)
[task 2021-06-08T00:11:02.680Z] 00:11:02     INFO -   3:57.09 ==12454==    by 0x115C0390: base::Thread::ThreadMain()+512 (checkouts/gecko/ipc/chromium/src/base/thread.cc:191)
[task 2021-06-08T00:11:02.680Z] 00:11:02     INFO -   3:57.09 ==12454==    by 0x115BCB29: ThreadFunc(void*)+9 (checkouts/gecko/ipc/chromium/src/base/platform_thread_posix.cc:40)
[task 2021-06-08T00:11:02.680Z] 00:11:02     INFO -   3:57.09 ==12454==    by 0x4E3E063: start_thread+195 (pthread_create.c:309)
[task 2021-06-08T00:11:02.680Z] 00:11:02     INFO -   3:57.09 ==12454==    by 0x5B6162C: clone+108 (clone.S:111)
[task 2021-06-08T00:11:02.680Z] 00:11:02     INFO -   3:57.09 ==12454==  Uninitialised value was created by a stack allocation
[task 2021-06-08T00:11:02.681Z] 00:11:02     INFO -   3:57.09 ==12454==    at 0x162AF01D: webrender::renderer::upload::upload_to_texture_cache+13 (upload.rs:50)

Comment 1

[Andrew Osmond [:aosmond] (he/him)]

Attachment: live_backing.zip

Comment 2

[Andrew Osmond [:aosmond] (he/him)]

https://treeherder.mozilla.org/logviewer?job_id=342050463&repo=autoland&lineNumber=64454

Comment 3

[Mike Hommey [:glandium]]

This was fixed in bug 1715132.