1715321 - Report the type of redirection in network markers

Status: RESOLVED FIXED

(Core :: Gecko Profiler, enhancement, P2)

Description

[Julien Wajsberg [:julienw]]

Network markers only capture that we're having a redirection, but not the type of this redirection. The goal of this bug is to report this information.

Comment 1

[Julien Wajsberg [:julienw]]

Attachment: Bug 1715321 - [profiler] Rework the existing test for redirections r=canaltinova

Now the test will warn when more properties than expected are received.
This way we won't forget to update the tests when we add more, but we
also assert that some properties are absent in some cases, as expected.

Comment 2

[Julien Wajsberg [:julienw]]

Attachment: Bug 1715321 - [profiler, netwerk] Reorder some parameters of profiler_add_network_marker r=gerald

This moves optional redirect-related parameters to the end, so that it's
easier to use in non-redirect cases.

Depends on D117679

Comment 3

[Julien Wajsberg [:julienw]]

Attachment: Bug 1715321 - [profiler] Add a parameter to profiler_add_network_marker to capture the type of redirect r=gerald

This commit also implements the changes to the marker streaming operation so
that this information is properly propagated to the frontend.

See https://github.com/firefox-devtools/profiler/pull/3350 for the
Firefox UI part.

Note that in debug builds, the new assertions will crash the browser,
until the following commit that uses this new parameter.

Depends on D117680

Comment 4

[Julien Wajsberg [:julienw]]

Attachment: Bug 1715321 - [profiler, netwerk] Report the type of redirection in network markers r=gerald

The profiler UI part has been landed in
https://github.com/firefox-devtools/profiler/pull/3350.

Depends on D117681

Comment 5

[Julien Wajsberg [:julienw]]

Attachment: image.png

Comment 6

[Julien Wajsberg [:julienw]]

Try is https://treeherder.mozilla.org/#/jobs?repo=try&revision=81bb892de40536ddd39e0ba171d7afb55189ce1a

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4da49f9d6f57
[profiler] Rework the existing test for redirections r=canaltinova

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/99512dadb64b
[profiler, netwerk] Reorder some parameters of profiler_add_network_marker r=necko-reviewers,gerald,valentin
https://hg.mozilla.org/integration/autoland/rev/251fe72f6cc2
[profiler] Add a parameter to profiler_add_network_marker to capture the type of redirect r=gerald
https://hg.mozilla.org/integration/autoland/rev/93f02f09ce30
[profiler, netwerk] Report the type of redirection in network markers r=necko-reviewers,gerald,valentin

Comment 9

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/4da49f9d6f57
https://hg.mozilla.org/mozilla-central/rev/99512dadb64b
https://hg.mozilla.org/mozilla-central/rev/251fe72f6cc2
https://hg.mozilla.org/mozilla-central/rev/93f02f09ce30