Closed Bug 1715345 Opened 2 months ago Closed 2 months ago

Attempting to convert to email to an event without loading message preview throws "Uncaught TypeError: can't access property "getSelection", getMessagePaneBrowser().contentWindow is null"

Categories

(Thunderbird :: General, defect)

defect

Tracking

(thunderbird_esr78 unaffected)

RESOLVED FIXED
91 Branch
Tracking Status
thunderbird_esr78 --- unaffected

People

(Reporter: lasana, Assigned: lasana)

Details

Attachments

(1 file)

STR:

  1. Open Thunderbird, do not select any messages.
  2. Right click on a mail message and click Convert To > Email.

Expected Results:
The new event dialog should load.

Actual Results:
Nothing loads, an error is thrown.

It appears that there is no contentWindow available (or access is restricted) when message pane displays the "Welcome to Thunderbird" screen.
https://searchfox.org/comm-central/source/calendar/base/content/calendar-extract.js#124

^ The code trying to access it however, appears to be specific to an extension and not necessary for the extraction to continue.

So should I remove the Thunderbird Conversations specific code or just ignore that block if the content window is not available?

Assignee: nobody → lasana
Flags: needinfo?(mkmelin+mozilla)
Flags: needinfo?(geoff)

Never mind, this can be fixed easily.

Flags: needinfo?(mkmelin+mozilla)
Flags: needinfo?(geoff)
Status: NEW → ASSIGNED
Target Milestone: --- → 91 Branch
Attachment #9225983 - Attachment description: Bug 1715345 - Do not attempt getSelection() if no contentWindow available when converting to event. r?darktrojan → Bug 1715345 - Do not attempt getSelection() if no contentWindow available when converting to event. r=darktrojan

Pushed by thunderbird@calypsoblue.org:
https://hg.mozilla.org/comm-central/rev/a294f959ab64
Do not attempt getSelection() if no contentWindow available when converting to event. r=darktrojan

Status: ASSIGNED → RESOLVED
Closed: 2 months ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.