Open Bug 1715378 Opened 3 years ago Updated 2 years ago

Rename BrowsingContextTargetActor `isTopLevel` attributes

Categories

(DevTools :: Framework, task)

Product:
DevTools
Component:
Framework
Type:
task

Tracking

(Not tracked)

People

(Reporter: ochameau, Unassigned)

References

(Blocks 1 open bug)

Details

This is a followup about this discussion: https://phabricator.services.mozilla.com/D117184#3815186

BrowsingContextTargetActor currently use isTopLevel attribute when emitting will-navigate/window-ready/window-destroyed/navigate.
But this attribute name is confused since we introduced fission as the top document of remote iframes will be flagged with isTopLevel=true, whereas remote iframes aren't really the tab's top level document.
This behavior conflicts with the isTopLevelTarget attribute on the target actor, which is working as expected. It is only true for the top level tab's target.

You need to log in before you can comment on or make changes to this bug.