Closed Bug 1715392 Opened 3 years ago Closed 3 years ago

[wpt-sync] Sync PR 29289 - Fix bug in audiobuffersource-duration-loop test

Categories

(Core :: Web Audio, task, P4)

task

Tracking

()

RESOLVED FIXED
91 Branch
Tracking Status
firefox91 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 29289 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/29289
Details from upstream follow.

b'Raymond Toy <rtoy@chromium.org>' wrote:

Fix bug in audiobuffersource-duration-loop test

The test was producing a failure that the array lengths didn't match.
(Not sure why the test was marked as passing even though it failed.)
The problem was that we actually had audioBuffer.getChannelData
instead of audioBuffer.getChannelData(0) to get the data from the
first channel.

Correct the mistake and also run clang-format over the code to clean
it up.

Bug: 1217791
Change-Id: I510838337e2948b89fb0622b63dd81e022d103d0
Reviewed-on: https://chromium-review.googlesource.com/2945641
WPT-Export-Revision: 7fa6b933bee08b2f42acbd03b893f3af2e4d745d

Component: web-platform-tests → Web Audio
Product: Testing → Core

CI Results

Ran 15 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 6 subtests

Status Summary

Firefox

OK : 1
PASS: 6

Chrome

OK : 1
PASS: 6

Safari

OK : 1
PASS: 6

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/67bd09c5ded7
[wpt PR 29289] - Fix bug in audiobuffersource-duration-loop test, a=testonly
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 91 Branch
Regressions: 1716677
Regressions: 1716678
You need to log in before you can comment on or make changes to this bug.