[wpt-sync] Sync PR 29289 - Fix bug in audiobuffersource-duration-loop test
Categories
(Core :: Web Audio, task, P4)
Tracking
()
Tracking | Status | |
---|---|---|
firefox91 | --- | fixed |
People
(Reporter: mozilla.org, Unassigned)
References
()
Details
(Whiteboard: [wptsync downstream])
Sync web-platform-tests PR 29289 into mozilla-central (this bug is closed when the sync is complete).
PR: https://github.com/web-platform-tests/wpt/pull/29289
Details from upstream follow.
b'Raymond Toy <rtoy@chromium.org>' wrote:
Fix bug in audiobuffersource-duration-loop test
The test was producing a failure that the array lengths didn't match.
(Not sure why the test was marked as passing even though it failed.)
The problem was that we actually had audioBuffer.getChannelData
instead of audioBuffer.getChannelData(0) to get the data from the
first channel.Correct the mistake and also run clang-format over the code to clean
it up.Bug: 1217791
Change-Id: I510838337e2948b89fb0622b63dd81e022d103d0
Reviewed-on: https://chromium-review.googlesource.com/2945641
WPT-Export-Revision: 7fa6b933bee08b2f42acbd03b893f3af2e4d745d
Assignee | ||
Updated•3 years ago
|
Assignee | ||
Comment 1•3 years ago
|
||
Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=ceb92379c2360cbca5859e49398006acbfd6e072
Assignee | ||
Comment 2•3 years ago
|
||
CI Results
Ran 15 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI
Total 1 tests and 6 subtests
Status Summary
Firefox
OK : 1
PASS: 6
Chrome
OK : 1
PASS: 6
Safari
OK : 1
PASS: 6
Links
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/67bd09c5ded7 [wpt PR 29289] - Fix bug in audiobuffersource-duration-loop test, a=testonly
Comment 4•3 years ago
|
||
bugherder |
Description
•