Closed Bug 1715394 Opened 3 years ago Closed 3 years ago

[wpt-sync] Sync PR 29290 - [TablesNG] Fix table height distributions over sections

Categories

(Core :: Layout: Tables, task, P4)

task

Tracking

()

RESOLVED FIXED
91 Branch
Tracking Status
firefox91 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(Blocks 1 open bug, )

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 29290 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/29290
Details from upstream follow.

b'Aleks Totic <atotic@chromium.org>' wrote:

[TablesNG] Fix table height distributions over sections

Incorrect height of an empty TBODY is the most widely reported
TablesNG bug.

The distribution algorithm was rewritten. My initial take
was bad. Legacy and FF disagreed on almost every test.
I failed to notice that they did agree on distributing
height to TBODYs first, even if bodies were empty.

Bug: 1216197
Change-Id: I3d16068a5d629aec442fb9c9717ed9edf45aaa66
Reviewed-on: https://chromium-review.googlesource.com/2946951
WPT-Export-Revision: 45e022369c4f6d7b86b1f540f873fb3f989e6d56

Component: web-platform-tests → Layout: Tables
Product: Testing → Core

CI Results

Ran 15 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 2 tests and 12 subtests

Status Summary

Firefox

OK : 2
PASS: 19[Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview] 25[Gecko-linux1804-64-debug, Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-linux1804-64-tsan-opt, Gecko-windows10-32-debug, Gecko-windows10-32-opt, Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, GitHub]
FAIL: 18[Gecko-linux1804-64-debug, Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-linux1804-64-tsan-opt, Gecko-windows10-32-debug, Gecko-windows10-32-opt, Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, GitHub] 24[Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview]

Chrome

OK : 2
PASS: 35
FAIL: 8

Safari

OK : 2
PASS: 21
FAIL: 22

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

Firefox-only Failures

/css/css-tables/tentative/table-height-redistribution.html
table 10: FAIL
table 12: FAIL
table 14: FAIL linked bug:Bug 1687619
table 30: FAIL
table 31: FAIL

New Tests That Don't Pass

/css/css-tables/tentative/table-height-redistribution.html
table 5: FAIL (Chrome: FAIL, Safari: FAIL)
table 7: FAIL (Chrome: PASS, Safari: FAIL)
table 10: FAIL (Chrome: PASS, Safari: PASS)
table 11: FAIL (Chrome: PASS, Safari: FAIL)
table 12: FAIL (Chrome: PASS, Safari: PASS)
table 14: FAIL (Chrome: PASS, Safari: PASS)
table 17: FAIL (Chrome: FAIL, Safari: PASS)
table 18: FAIL [Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview], PASS [Gecko-linux1804-64-debug, Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-linux1804-64-tsan-opt, Gecko-windows10-32-debug, Gecko-windows10-32-opt, Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, GitHub] (Chrome: FAIL, Safari: PASS)
table 19: FAIL [Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview], PASS [Gecko-linux1804-64-debug, Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-linux1804-64-tsan-opt, Gecko-windows10-32-debug, Gecko-windows10-32-opt, Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, GitHub] (Chrome: PASS, Safari: PASS)
table 20: FAIL [Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview], PASS [Gecko-linux1804-64-debug, Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-linux1804-64-tsan-opt, Gecko-windows10-32-debug, Gecko-windows10-32-opt, Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, GitHub] (Chrome: PASS, Safari: PASS)
table 21: FAIL [Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview], PASS [Gecko-linux1804-64-debug, Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-linux1804-64-tsan-opt, Gecko-windows10-32-debug, Gecko-windows10-32-opt, Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, GitHub] (Chrome: FAIL, Safari: PASS)
table 22: FAIL [Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview], PASS [Gecko-linux1804-64-debug, Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-linux1804-64-tsan-opt, Gecko-windows10-32-debug, Gecko-windows10-32-opt, Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, GitHub] (Chrome: FAIL, Safari: PASS)
table 25: FAIL (Chrome: FAIL, Safari: FAIL)
table 27: FAIL (Chrome: PASS, Safari: FAIL)
table 28: FAIL (Chrome: FAIL, Safari: FAIL)
table 29: FAIL (Chrome: PASS, Safari: FAIL)
table 30: FAIL (Chrome: PASS, Safari: PASS)
table 31: FAIL (Chrome: PASS, Safari: PASS)
/css/css-tables/tentative/tbody-height-redistribution.html
table 7: FAIL [Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview], PASS [Gecko-linux1804-64-debug, Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-linux1804-64-tsan-opt, Gecko-windows10-32-debug, Gecko-windows10-32-opt, Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, GitHub] (Chrome: PASS, Safari: FAIL)
table 8: FAIL (Chrome: PASS, Safari: FAIL)
table 9: FAIL (Chrome: PASS, Safari: FAIL)
table 10: FAIL (Chrome: FAIL, Safari: FAIL)
table 11: FAIL (Chrome: PASS, Safari: FAIL)
table 12: FAIL (Chrome: PASS, Safari: FAIL)

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/17833e79271b
[wpt PR 29290] - [TablesNG] Fix table height distributions over sections, a=testonly
https://hg.mozilla.org/integration/autoland/rev/6f199515b4cb
[wpt PR 29290] - Update wpt metadata, a=testonly
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 91 Branch
You need to log in before you can comment on or make changes to this bug.