1715399 - [wpt-sync] Sync PR 29294 - Only check slot assignments for non-UA shadow roots

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, task, P4)

Description

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 29294 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/29294
Details from upstream follow.

b'Mason Freed <[e-mail]>' wrote:

Only check slot assignments for non-UA shadow roots

This DCHECK can be hit for UA shadow roots because the tree
gets walked (at [1]) each time assignments are checked. This is
not the case for non-UA slots, so just restrict this check to
author shadow roots.

[1] https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/renderer/core/dom/slot_assignment.cc;l=28;drc=0a0f5cb6f9820754390d319ccce4ae3865f954d1

Fixed: 1216804
Change-Id: I2f4120e9d5c965ad73c6cd87f9fd9fc0f3dbb5f4

Reviewed-on: https://chromium-review.googlesource.com/2945954
WPT-Export-Revision: 6db5130ebb7a4ecbdbfccd80687701cc6c34dded

Comment 1

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=b1bbb4e5300f5d863cf1b7be44ce93ce245032a5

Comment 2

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

CI Results

Ran 15 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests

Status Summary

Firefox

PASS: 1

Chrome

PASS: 1

Safari

PASS: 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/aafc18063713
[wpt PR 29294] - Only check slot assignments for non-UA shadow roots, a=testonly

Comment 4

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/aafc18063713